fix parsing EXPO_APPLE_PROVIER_ID env var #2349
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louix
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
|
/changelog-entry bug-fix fix parsing EXPO_APPLE_PROVIER_ID env var |
sjchmiela
approved these changes
Apr 29, 2024
|
Sure, yeah sorry I should have run prettier. Is the /changelog-entry thing broken? Manually added it anyway. |
It seems to be broken for external contributors 🤔 I will take a look at it later on. Meanwhile, feel free to ignore this failed changelog action and merge the PR |
|
I cannot merge this PR by the way, so I assume someone on your side needs to.
|
|
@sjchmiela @szdziedzic could you merge the PR since I do not have write access |
|
merged ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
getenv.int(process.env.EXPO_APPLE_PROVIER_ID)will lookup the value of theprocess.env.EXPO_APPLE_PROVIER_IDinprocess.env(i.e.process.env[process.env.EXPO_APPLE_PROVIER_ID]) and try to parse that (undefined value) as an int.If at runtime
process.env.EXPO_APPLE_PROVIER_IDis12345, the code will fail with:Where process.env["12345"] does not exist.
Test Plan
Simply try to set EXPO_APPLE_PROVIER_ID to anything on the current eas-cli build.