[ENG-12115][eas-cli] add eas onboarding flow #2338

szdziedzic · 2024-04-23T13:33:47Z

Why

Add onboarding flow for EAS

https://linear.app/expo/issue/ENG-12115/add-eas-onboarding-command-to-automatically-execute-all-of-the

How

Add onboarding flow for EAS

Test Plan

Test manually

codecov · 2024-04-23T13:37:15Z

Codecov Report

Attention: Patch coverage is 22.88557% with 155 lines in your changes are missing coverage. Please review.

Project coverage is 53.64%. Comparing base (de8956c) to head (59823b1).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...ackages/eas-cli/src/commands/project/onboarding.ts	23.92%	61 Missing and 9 partials ⚠️
packages/eas-cli/src/onboarding/runCommand.ts	16.00%	21 Missing ⚠️
packages/eas-cli/src/vcs/clients/git.ts	0.00%	21 Missing ⚠️
packages/eas-cli/src/onboarding/git.ts	21.74%	17 Missing and 1 partial ⚠️
...ages/eas-cli/src/onboarding/installDependencies.ts	18.19%	9 Missing ⚠️
...i/src/graphql/mutations/UserPreferencesMutation.ts	36.37%	7 Missing ⚠️
packages/eas-cli/src/vcs/git.ts	28.58%	5 Missing ⚠️
...ials/manager/SetUpBuildCredentialsCommandAction.ts	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   53.83%   53.64%   -0.19%     
==========================================
  Files         525      530       +5     
  Lines       19275    19479     +204     
  Branches     4074     4120      +46     
==========================================
+ Hits        10375    10447      +72     
- Misses       8180     8302     +122     
- Partials      720      730      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

linear · 2024-04-24T11:57:35Z

ENG-12115 Add `eas onboarding` command to automatically execute all of the commands and setup credentials for the user

github-actions · 2024-04-30T11:53:25Z

Size Change: +7.5 kB (0%)

Total Size: 51.3 MB

Filename	Size	Change
`./packages/eas-cli/dist/eas-linux-x64.tar.gz`	51.3 MB	+7.5 kB (0%)

_{compressed-size-action}

radoslawkrzemien · 2024-05-08T12:49:07Z

packages/eas-cli/src/commands/project/onboarding.ts

+
+    if (!actor.preferences.onboarding) {
+      throw new Error(
+        'This command is a continuation of the onboarding process started on the Expo website. Start the onboarding process on the website before running this command. Visit https:/expo.new to create an account and start the onboarding process.'


Nit: https:/expo.new -> https://expo.new

radoslawkrzemien · 2024-05-08T12:53:37Z

packages/eas-cli/src/commands/project/onboarding.ts

+  actor: Actor;
+}): DynamicConfigContextFn {
+  return async (options?: ExpoConfigOptions) => {
+    const expBefore = getPrivateExpoConfig(projectDir, options);


Why not reuse getPrivateExpoConfigWithProjectIdAsync here?

sjchmiela · 2024-05-08T13:31:58Z

packages/eas-cli/src/vcs/clients/git.ts

@@ -17,6 +17,10 @@ import {
 import { Client } from '../vcs';

 export default class GitClient extends Client {
+  constructor(private maybeCwdOverride?: string) {


Would it make sense to instead have this.cwd = findWorkspaceRoot(cwd) ?? cwd?

I think we are not always running it workspace root (for example when git adding something), this can be risky and can break something

packages/eas-cli/src/onboarding/runCommand.ts

packages/eas-cli/src/onboarding/git.ts

sjchmiela · 2024-05-08T13:40:15Z

packages/eas-cli/src/graphql/mutations/UserPreferencesMutation.ts

+                    appId
+                    isCLIDone


Interesting — can a single user only have a single preferences entry for a single app?

I believe so, cc: @tchayen

Yup! This is an interactive wizard on the website. We don't allow people to run more than one at the same time. If they have such a need they probably don't need an interactive wizard in the first place.

And everything we do here can be automated as well by the user if they ever need that.

packages/eas-cli/src/commands/project/onboarding.ts

sjchmiela · 2024-05-08T13:56:57Z

packages/eas-cli/src/commands/project/onboarding.ts

+    const githubUsername = app.githubRepository
+      ? app.githubRepository.metadata.githubRepoOwnerName
+      : 'expo';
+    const githubRepositoryName = app.githubRepository
+      ? app.githubRepository.metadata.githubRepoName
+      : 'expo-default-template';


nit: if one is defined, but not the other we'd try to clone sjchmiela/expo-default-template? Seems like we shouldn't

both githubRepoOwnerName and githubRepoName are reguired on metadata object

so I believe there should never be a case when one exists and other not

packages/eas-cli/src/commands/project/onboarding.ts

github-actions · 2024-05-08T14:48:54Z

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

szdziedzic changed the title ~~[eas-cli] add eas onboarding flow~~ [ENG-12115][eas-cli] add eas onboarding flow Apr 24, 2024

szdziedzic force-pushed the @szdziedzic/eas-onboarding-flow branch from e15b190 to 41b58b0 Compare April 30, 2024 11:50

szdziedzic added 4 commits May 8, 2024 11:17

[eas-cli] add eas onboarding flow

901a147

mark command as hidden and prompt user before starting any action

9187c3d

add gql queries

9614095

regenerate gql schema

5026f1e

szdziedzic force-pushed the @szdziedzic/eas-onboarding-flow branch from 41b58b0 to 5026f1e Compare May 8, 2024 12:38

szdziedzic marked this pull request as ready for review May 8, 2024 12:39

szdziedzic requested review from khamilowicz and sjchmiela as code owners May 8, 2024 12:39

szdziedzic requested a review from radoslawkrzemien May 8, 2024 12:39

fix type issues

b90e82b

khamilowicz approved these changes May 8, 2024

View reviewed changes

radoslawkrzemien approved these changes May 8, 2024

View reviewed changes

szdziedzic added 2 commits May 8, 2024 15:08

mark isCLIDone as true

23257c5

apply suggested changes

446fea5

szdziedzic added the no changelog PR that doesn't require a changelog entry label May 8, 2024

sjchmiela approved these changes May 8, 2024

View reviewed changes

szdziedzic added 2 commits May 8, 2024 16:26

improvements after cr

52e0c57

more improvements

59823b1

szdziedzic merged commit a740aa1 into main May 8, 2024
9 checks passed

szdziedzic deleted the @szdziedzic/eas-onboarding-flow branch May 8, 2024 14:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ENG-12115][eas-cli] add eas onboarding flow #2338

[ENG-12115][eas-cli] add eas onboarding flow #2338

szdziedzic commented Apr 23, 2024 •

edited

Loading

codecov bot commented Apr 23, 2024 •

edited

Loading

linear bot commented Apr 24, 2024

github-actions bot commented Apr 30, 2024 •

edited

Loading

radoslawkrzemien May 8, 2024

radoslawkrzemien May 8, 2024

szdziedzic May 8, 2024

sjchmiela May 8, 2024

szdziedzic May 8, 2024 •

edited

Loading

sjchmiela May 8, 2024

szdziedzic May 8, 2024

tchayen May 8, 2024

sjchmiela May 8, 2024

szdziedzic May 8, 2024

szdziedzic May 8, 2024

github-actions bot commented May 8, 2024

[ENG-12115][eas-cli] add eas onboarding flow #2338

[ENG-12115][eas-cli] add eas onboarding flow #2338

Conversation

szdziedzic commented Apr 23, 2024 • edited Loading

Why

How

Test Plan

codecov bot commented Apr 23, 2024 • edited Loading

Codecov Report

linear bot commented Apr 24, 2024

github-actions bot commented Apr 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

szdziedzic May 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented May 8, 2024

szdziedzic commented Apr 23, 2024 •

edited

Loading

codecov bot commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 30, 2024 •

edited

Loading

szdziedzic May 8, 2024 •

edited

Loading