-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] [ENG-11602] Update eas.schema.json #2337
Merged
radoslawkrzemien
merged 7 commits into
main
from
@radoslawkrzemien/ENG-11602-update-eas-schema-json-with-new-images
Apr 23, 2024
Merged
[eas-cli] [ENG-11602] Update eas.schema.json #2337
radoslawkrzemien
merged 7 commits into
main
from
@radoslawkrzemien/ENG-11602-update-eas-schema-json-with-new-images
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the eas.schema.json with the current image values for Android images See: https://linear.app/expo/issue/ENG-11310/fix-warnings-errors-that-come-up-when-adding-eas-to-a-react-native-cli
radoslawkrzemien
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
April 23, 2024 12:44
Updated the eas.schema.json with the current image values for Android images See: https://linear.app/expo/issue/ENG-11602/preinstall-gradle-and-ndks-used-in-the-3-latests-sdks-on-android
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2337 +/- ##
=======================================
Coverage 53.67% 53.67%
=======================================
Files 525 525
Lines 19268 19268
Branches 4068 4068
=======================================
Hits 10340 10340
Misses 8203 8203
Partials 725 725 ☔ View full report in Codecov by Sentry. |
Size Change: -3.79 kB (0%) Total Size: 51.4 MB
|
szdziedzic
approved these changes
Apr 23, 2024
…-11602-update-eas-schema-json-with-new-images
/changelog-entry chore Update the list of available Android images |
✅ Thank you for adding the changelog entry! |
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-11602-update-eas-schema-json-with-new-images
branch
April 23, 2024 18:17
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Companion to: https://github.com/expo/turtle-v2/pull/1744
https://linear.app/expo/issue/ENG-11602/preinstall-gradle-and-ndks-used-in-the-3-latests-sdks-on-android
New options for Android images have been added and eas.schema.json needs to reflect that
How
Updated the eas.schema.json with the current image values for Android images
Test Plan
Automated tests pass