[ENG-12057][eas-cli] don't prompt user to set android.package and ios.bundleIdentifier value when runing in non-interactive mode
#2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentifier` value when runing in non-interactive mode
|
/changelog-entry bug-fix Don't prompt to set |
|
Size Change: -627 B (0%) Total Size: 51.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
+ Coverage 53.66% 53.67% +0.01%
==========================================
Files 525 525
Lines 19264 19268 +4
Branches 4066 4068 +2
==========================================
+ Hits 10336 10340 +4
Misses 8203 8203
Partials 725 725 ☔ View full report in Codecov by Sentry. |
radoslawkrzemien
approved these changes
Apr 22, 2024
| }) | ||
| ).rejects.toThrowError(/we can't update this file programmatically/); | ||
| }); | ||
| it('throws an error if using app.config.js', async () => { |
There was a problem hiding this comment.
Duplicated test name
|
✅ Thank you for adding the changelog entry! |
szdziedzic
deleted the
@szdziedzic/do-not-prompt-to-set-bundle-identifier-in-non-interactive-mode
branch
This was referenced Sep 9, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-12057/fail-with-a-nice-and-meaningful-error-message-if-iosbundleidentifier
How
Throw meaningful error instead
Test Plan
Tests