[eas-cli] mark default image tag and old images as deprecated and add new image tags to eas.schema.json
#2298
Conversation
szdziedzic
changed the title
default image tag as deprecateddefault image tag as deprecated and add new image tags to eas.schema.json
|
Size Change: -43 B (0%) Total Size: 51.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
==========================================
- Coverage 53.67% 53.65% -0.01%
==========================================
Files 525 525
Lines 19160 19167 +7
Branches 4043 4047 +4
==========================================
Hits 10282 10282
- Misses 8152 8158 +6
- Partials 726 727 +1 ☔ View full report in Codecov by Sentry. |
|
/changelog-entry chore Deprecate the |
|
/changelog-entry new-feature Add |
|
/changelog-entry chore Deprecate Android images with JDK 8 and NDK |
szdziedzic
force-pushed
the
@szdziedzic/deprecate-default-tag
branch
2 times, most recently
from
1aa370d to
fe8fd8a
Compare
szdziedzic
changed the title
default image tag as deprecated and add new image tags to eas.schema.jsondefault image tag and old images as deprecated and add new image tags to eas.schema.json
| "This image is deprecated, please use one of the more recent images instead." | ||
| "This image tag is deprecated, please use other image tags or images directly instead.", | ||
| "This image tag is deprecated, please use other image tags or images directly instead.", | ||
| "This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates.", |
There was a problem hiding this comment.
Should the URL have https? I think I saw vscode linkifying links in descriptions?
|
@sjchmiela You are right, I will remove the Android image warnings for now because I will be able to give people more helpful instructions on what to do next once https://github.com/expo/turtle-v2/pull/1744 lands and we have more images with newer NDKs better suited for SDK 49 and 50. Will open a separate PR to add Android images warnings 👍. |
szdziedzic
force-pushed
the
@szdziedzic/deprecate-default-tag
branch
from
fe8fd8a to
5c9dbd3
Compare
|
✅ Thank you for adding the changelog entry! |
Why
The current
defaultimage tag is confusing. It's not even the true default. Changing it breaks people's builds and so on...Let's deprecate it.
Add a new
autotag that is an explicit way of opting into the true default behavior (auto-resolving image when it is not specified ineas.json).Add
sdk-XYtagsDeprecate images with Xcode < 15 because of https://expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates. Advise people on how to switch to Xcode 15 image.
Deprecate old Android images.
More context: https://exponent-internal.slack.com/archives/C9PRD479V/p1710257552292179
expo/expo#27852
https://github.com/expo/turtle-v2/pull/1736
How
Mark the
defaultimage tag as deprecatedAdd a new
autotag that is an explicit way of opting into the true default behavior (auto-resolving image when it is not specified ineas.json).Add
sdk-XYtagsDeprecate images with Xcode < 15 because of https://expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates. Advise people on how to switch to Xcode 15 image.
Deprecate old Android images with JDK 8 (used in auto image resolving logic for RN < 0.68.0) and NDK r19c (used for SDK < 46).
Test Plan
Test manually