Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config property to eas.schema.json #2248

Merged

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Feb 23, 2024

Why

We want users to feel like they're adding something we support.

How

Added config property to build profile level and platform-specific profile properties levels.

Also prettified the file according to my JSON Tools VS Code extension. Let me know if it should be deprettified.

Test Plan

None.

Copy link

linear bot commented Feb 23, 2024

@sjchmiela
Copy link
Contributor Author

/changelog-entry bug-fix Add missing config property to eas.json schema.

Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: -667 B (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -667 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.02%. Comparing base (b6b22b7) to head (ddb8696).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2248   +/-   ##
=======================================
  Coverage   54.02%   54.02%           
=======================================
  Files         519      519           
  Lines       18935    18935           
  Branches     3798     3798           
=======================================
  Hits        10228    10228           
  Misses       8686     8686           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela merged commit 7d47060 into main Feb 23, 2024
9 checks passed
@sjchmiela sjchmiela deleted the stanley/eng-11501-add-config-to-easjson-vs-code-suggestions branch February 23, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants