[eas-cli] fix expo-updates fingerprinting during update #2231
+135
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
requested review from
EvanBacon,
byCedric,
szdziedzic,
khamilowicz and
sjchmiela
as code owners
wschurman
requested review from
Kudo and
quinlanj
and removed request for
sjchmiela,
khamilowicz,
EvanBacon and
szdziedzic
|
Size Change: +1.8 kB (0%) Total Size: 51.3 MB
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2231 +/- ##
==========================================
- Coverage 54.09% 54.04% -0.04%
==========================================
Files 518 519 +1
Lines 18890 18922 +32
Branches 3784 3789 +5
==========================================
+ Hits 10216 10225 +9
- Misses 8653 8676 +23
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Kudo
approved these changes
Feb 16, 2024
quinlanj
approved these changes
Feb 16, 2024
wschurman
force-pushed
the
@wschurman/fix-fingerprint
branch
from
8388d85 to
8432cc4
Compare
|
/changelog-entry new-feature Fix expo-updates fingerprinting during update |
|
✅ Thank you for adding the changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Successor to #2225 (previous attempt at this).
This PR calls in to the new
expo-updatesCLI command to generate the fingerprint: expo/expo#27119. This ensures that the version of the fingerprint package being used is consistent between builds and thiseas updatecommand when calculating the runtime version.How
In test bare app in expo/expo repo with all the modules installed locally (checked out to expo/expo#27119), run
neas update -p iosand ensure the fingerprint matches.Test Plan
Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.