Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for bumping eas-build dependencies #2216

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Feb 6, 2024

Why

It is currently not possible to use if: ${ always() } in Custom Build workflows due to outdated @expo/steps dependency.

How

Added a GitHub workflow, similar to the one we have in turtle-v2, which will automatically upgrade all dependencies from the eas-build repo.

Test Plan

#2220

Copy link

github-actions bot commented Feb 6, 2024

Size Change: -113 B (0%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB -113 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69b0eda) 54.16% compared to head (e1c8c81) 54.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2216   +/-   ##
=======================================
  Coverage   54.16%   54.16%           
=======================================
  Files         516      516           
  Lines       18814    18814           
  Branches     3969     3969           
=======================================
  Hits        10188    10188           
  Misses       7934     7934           
  Partials      692      692           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela force-pushed the stanley/upgrade-eas-build branch from df92537 to 776bbd4 Compare February 6, 2024 21:48
@sjchmiela sjchmiela changed the title Upgrade @expo/steps and add a workflow for triggering Upgrade @expo/steps and add a workflow for triggering Feb 6, 2024
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela marked this pull request as ready for review February 6, 2024 22:26
@sjchmiela sjchmiela changed the title Upgrade @expo/steps and add a workflow for triggering Add workflow for bumping eas-build dependencies Feb 6, 2024
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sjchmiela sjchmiela merged commit 048460f into main Feb 7, 2024
9 of 10 checks passed
@sjchmiela sjchmiela deleted the stanley/upgrade-eas-build branch February 7, 2024 11:39
sjchmiela added a commit to expo/eas-build that referenced this pull request Feb 7, 2024
# Why

Companion to expo/eas-cli#2216

# How

Copied the `turtle-v2` step.

# Test Plan

I'll only get to test it when a new version is released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants