Revert "Revert "[eas-json] validate EAS Submit inputs better"" #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4.7 kB (0%) Total Size: 51.5 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2202 +/- ##
==========================================
+ Coverage 54.14% 54.16% +0.03%
==========================================
Files 516 516
Lines 18798 18808 +10
Branches 3769 3772 +3
==========================================
+ Hits 10176 10186 +10
Misses 8601 8601
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
/changelog-entry chore Add better validation for EAS Submit inputs |
szdziedzic
requested review from
sjchmiela,
radoslawkrzemien,
quinlanj,
wschurman,
ide and
brentvatne
sjchmiela
approved these changes
Jan 29, 2024
Co-authored-by: Stanisław Chmiela <[email protected]>
wschurman
approved these changes
Jan 29, 2024
| @@ -111,6 +111,11 @@ export default class IosSubmitCommand { | |||
| const envAppSpecificPassword = getenv.string('EXPO_APPLE_APP_SPECIFIC_PASSWORD', ''); | |||
|
|
|||
| if (envAppSpecificPassword) { | |||
| if (!/^[a-z]{4}-[a-z]{4}-[a-z]{4}-[a-z]{4}$/.test(envAppSpecificPassword)) { | |||
| throw new Error( | |||
| 'EXPO_APPLE_APP_SPECIFIC_PASSWORD must be in the format XXXX-XXXX-XXXX-XXXX, where X is a lowercase letter.' | |||
There was a problem hiding this comment.
Suggested change
| 'EXPO_APPLE_APP_SPECIFIC_PASSWORD must be in the format XXXX-XXXX-XXXX-XXXX, where X is a lowercase letter.' | |
| 'EXPO_APPLE_APP_SPECIFIC_PASSWORD must be in the format xxxx-xxxx-xxxx-xxxx, where x is a lowercase letter.' |
| appleTeamId: Joi.string() | ||
| .regex(/^[\dA-Z]{10}$/) // Apple says that it always has to be 10 characters long https://developer.apple.com/help/account/manage-your-team/locate-your-team-id/ | ||
| .message( | ||
| 'Invalid Apple Team ID was specified. It should consist of 10 uppercase letters or digits. Example: "AB32CDE81F".' |
There was a problem hiding this comment.
Suggested change
| 'Invalid Apple Team ID was specified. It should consist of 10 uppercase letters or digits. Example: "AB32CDE81F".' | |
| 'Invalid Apple Team ID was specified. It should consist of 10 uppercase letters or digits. Example: "AB32CZE81F".' |
(so as not to confuse with hex, let's add some non-hex characters in the example)
|
✅ Thank you for adding the changelog entry! |
szdziedzic
deleted the
revert-2200-revert-2198-@szdziedzic/sanitize-values-in-eas-submit-profile-better
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Apply changes from #2198 with fixes
How
Same as for #2198, but I made constraints for validating
ascApiKeyIdandascAppIdmore loose and added some comments.Test plan
Tests