Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Support requireCommit for EAS Update #2196

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

wschurman
Copy link
Member

Why

When the requireCommit preference has been set in eas.json (cli section), the eas update command should read and respect that preference.

Closes ENG-11110.

How

Apply same function calls as build/submit.

Test Plan

  1. Add requireCommit: true to eas.json cli section
$ neas update

Warning! Your repository working tree is dirty.
This operation needs to be run on a clean working tree. Commit all your changes before proceeding.
✖ Commit changes to git? … yes

Copy link

linear bot commented Jan 22, 2024

@wschurman wschurman requested review from quinlanj and removed request for byCedric and EvanBacon January 22, 2024 18:18
@wschurman
Copy link
Member Author

/changelog-entry new-feature Support requireCommit for EAS Update

Copy link

✅ Thank you for adding the changelog entry!

Copy link

Size Change: +199 B (0%)

Total Size: 51.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.5 MB +199 B (0%)

compressed-size-action

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ea0579) 54.10% compared to head (6d46fcd) 54.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
+ Coverage   54.10%   54.14%   +0.04%     
==========================================
  Files         516      516              
  Lines       18795    18798       +3     
  Branches     3769     3769              
==========================================
+ Hits        10167    10176       +9     
+ Misses       8607     8601       -6     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman wschurman merged commit b5f2f52 into main Jan 22, 2024
9 checks passed
@wschurman wschurman deleted the @wschurman/require-commit-eas-update branch January 22, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants