-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-10922][eas-json] add new Xcode 15.1 image to eas.schema.json
#2155
[ENG-10922][eas-json] add new Xcode 15.1 image to eas.schema.json
#2155
Conversation
/changelog-entry chore Add new Xcode 15.1 image to |
Size Change: +435 B (0%) Total Size: 55.5 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2155 +/- ##
=======================================
Coverage 54.20% 54.20%
=======================================
Files 509 509
Lines 18657 18657
Branches 3736 3736
=======================================
Hits 10112 10112
Misses 8524 8524
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me. @brentvatne, do we need to post a changelog about upcoming default
change from macos-ventura-13.4-xcode-14.3.1
to macos-ventura-13.6-xcode-15.0
?
eas.schema.json
eas.schema.json
@szdziedzic and i discussed this a bit today. were you referring to the "explicit default" case (where someone specifies |
b10975e
to
c710b22
Compare
❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you. |
Why
We are adding Xcode 15.1 image
How
Add new Xcode 15.1 image to
eas.schema.json
Test Plan
Tests