Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] fix yarn lint-changelog and use node 18.19.0 by default #2153

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

szdziedzic
Copy link
Member

Why

yarn lint-changelog is failing on main

It broke since our tests started to use the newly published Node 18.19.0

Seems like an issue with ts-node.

How

Bump default Node used across EAS CLI to 18.19.0.

Change scripts to use
TypeStrong/ts-node#1997 (comment)

Test Plan

Tests

@szdziedzic szdziedzic changed the title fix lint changelog and use node 18.19.0 by default [ci] fix yarn lint-changelog and use node 18.19.0 by default Dec 14, 2023
@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label Dec 14, 2023
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@szdziedzic szdziedzic requested a review from sjchmiela December 14, 2023 15:04
Copy link

Size Change: -214 B (0%)

Total Size: 55.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 55.5 MB -214 B (0%)

compressed-size-action

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0012f5) 54.20% compared to head (2a12228) 54.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2153   +/-   ##
=======================================
  Coverage   54.20%   54.20%           
=======================================
  Files         509      509           
  Lines       18657    18657           
  Branches     3736     3736           
=======================================
  Hits        10112    10112           
  Misses       8524     8524           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic marked this pull request as ready for review December 14, 2023 15:09
Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@szdziedzic szdziedzic merged commit 899a563 into main Dec 15, 2023
10 of 11 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/test-fixing-lint-changelog branch December 15, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants