[eas-cli] Always refresh provisioning profile #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are other cases when the provisioning profile needs to be refreshed before use and which cannot be easily validated at runtime without bigger changes in the code. It is simpler (at least for the time being) to just refresh existing profile each time See: https://exponent-internal.slack.com/archives/C9PRD479V/p1700236895524379 https://exponent-internal.slack.com/archives/C9PRD479V/p1700229660146479
radoslawkrzemien
requested review from
szdziedzic and
khamilowicz
as code owners
kadikraman
approved these changes
Nov 17, 2023
|
Size Change: +219 B (0%) Total Size: 42.3 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2125 +/- ##
==========================================
- Coverage 54.19% 54.19% -0.00%
==========================================
Files 509 509
Lines 18663 18660 -3
Branches 3742 3741 -1
==========================================
- Hits 10113 10110 -3
Misses 8529 8529
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
/changelog-entry bug-fix Always refresh existing provisioning profile before use |
|
✅ Thank you for adding the changelog entry! |
szdziedzic
approved these changes
Nov 17, 2023
szdziedzic
deleted the
@radoslawkrzemien/always-refresh-provisioning-profile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://exponent-internal.slack.com/archives/C9PRD479V/p1700236895524379
https://exponent-internal.slack.com/archives/C9PRD479V/p1700229660146479
How
There are other cases when the provisioning profile needs to be refreshed before use and which cannot be easily validated at runtime without bigger changes in the code. It is simpler (at least for the time being) to just refresh existing profile each time
Test Plan
Run automated tests