[eas-cli] [ENG-10555] Fix device provsioning

[radoslawkrzemien]

Why

https://linear.app/expo/issue/ENG-10555/ios-devices-get-stuck-in-failed-to-provision-state-until-the-developer
https://www.reddit.com/r/expo/comments/17kr7rr/failed_to_provision/?sort=new

How

The problem happened when the provisioning profile already existed and the user wanted to add new devices to it. In such a case, a missing device was added to the Apple Developer Portal if needed, but the provisioning profile from EAS was used unchanged. This meant that no matter what the devices list in the provisioning profile used was the same as before and thus resulted in a warning message and a failure.
Now another check has been added, if the id of the profile from EAS matches the one from Apple the list of devices is compared. If it's the same then the profile is reused as before. If the list is different then the profile in EAS gets updated first with the current devices data from Apple

Test Plan

Tested manually by reproducing the issue mentioned by the users, applying fix and confirming that the issue went away.
Also added an automated test to cover the new case and adjusted existing tests

[linear]

ENG-10555 iOS devices get stuck in "Failed to provision" state until the developer deletes their provisioning profile

See this Reddit thread:

Hi guys i added a device to the list of devices but getting this error below saying that the device is in "Processing". However the device is listed as "Active". Has anybody faced the same problem? Could it be related with the fact that i have the last iPhone 15 pro?

Failed to provision 1 of the selected devices:
- UDID (iPhone)
Most commonly devices fail to to be provisioned while they are still being processed by Apple, which can take up to 24-72 hours. Check your Apple Developer Portal page at https://developer.apple.com/account/resources/devices/list, the devices in "Processing" status cannot be provisioned yet

Someone posted a solution:

For anyone still having any trouble with this, I found that in order to get the provisioning profile to update with the new devices, I had to delete it and start a new build. This then generates a new profile with the new devices.

I had to run eas credentials > iOS > preview > Build Credentials > Provisioning Profile > Delete

Then run your build as normal.

It's good that developers have a workaround. However, it would be even better if they did not have to manually delete their provisioning profile, and if their device is listed as "Active" on the Apple Developer website, we should not continue to treat the device as being in the "Processing" state.

[radoslawkrzemien]

/changelog-entry bug-fix Fixed provisioning of new devices into an existing profile

[codecov]

Codecov Report

Merging #2119 (acedc94) into main (5e31a9d) will increase coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
+ Coverage   54.20%   54.21%   +0.01%     
==========================================
  Files         509      509              
  Lines       18653    18657       +4     
  Branches     3739     3740       +1     
==========================================
+ Hits        10109    10113       +4     
  Misses       8523     8523              
  Partials       21       21              

Files	Coverage Δ
...tials/ios/actions/SetUpAdhocProvisioningProfile.ts	43.71% <80.00%> (+1.54%)	⬆️

[github-actions]

✅ Thank you for adding the changelog entry!

[github-actions]

Size Change: -90 B (0%)

Total Size: 42.3 MB

Filename	Size	Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz	42.3 MB	-90 B (0%)

_{compressed-size-action}

[szdziedzic]

Nice! Looks reasonable