-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-10566][eas-cli] add selectedImage
and customNodeVersion
to build metadata
#2113
[ENG-10566][eas-cli] add selectedImage
and customNodeVersion
to build metadata
#2113
Conversation
ENG-10566 Create a banner that links people to changelog on build details pages with Node 16
|
@@ -63,6 +63,7 @@ export async function collectMetadataAsync<T extends Platform>( | |||
customWorkflowName: ctx.customBuildConfigMetadata?.workflowName, | |||
developmentClient: ctx.developmentClient, | |||
requiredPackageManager: ctx.requiredPackageManager ?? undefined, | |||
selectedImage: ctx.buildProfile.image, | |||
}; | |||
return sanitizeMetadata(metadata); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update sanitizeMetadata
and bump here, don't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's right, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Size Change: -289 kB (-1%) Total Size: 42.3 MB
|
Codecov Report
@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
+ Coverage 54.19% 54.19% +0.01%
==========================================
Files 509 509
Lines 18656 18657 +1
Branches 3936 3739 -197
==========================================
+ Hits 10109 10110 +1
- Misses 7860 8526 +666
+ Partials 687 21 -666
|
/changelog-entry chore Add |
✅ Thank you for adding the changelog entry! |
selectedImage
to build metadataselectedImage
and customNodeVersion
to build metadata
Why
To accomplish https://linear.app/expo/issue/ENG-10566/create-a-banner-that-links-people-to-changelog-on-build-details-pages www needs to know which image was selected by the user to run the build on and if custom node version was selected.
Companion to https://github.com/expo/universe/pull/13889
How
Add the
selectedImage
andcustomNodeVersion
field to the build's metadataTest Plan
After https://github.com/expo/universe/pull/13889 is merged and I regenerate GQL schema test manually