Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-10566][eas-cli] add selectedImage and customNodeVersion to build metadata #2113

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Nov 7, 2023

Why

To accomplish https://linear.app/expo/issue/ENG-10566/create-a-banner-that-links-people-to-changelog-on-build-details-pages www needs to know which image was selected by the user to run the build on and if custom node version was selected.

Companion to https://github.com/expo/universe/pull/13889

How

Add the selectedImage and customNodeVersion field to the build's metadata

Test Plan

After https://github.com/expo/universe/pull/13889 is merged and I regenerate GQL schema test manually

Copy link

linear bot commented Nov 7, 2023

ENG-10566 Create a banner that links people to changelog on build details pages with Node 16

  • The banner should say "Effective November 27, 2023, the default Node version will be upgraded from 16 to 18. This build uses v16.18.1, and this will become v18.18.2 on the effective date. Learn more."
  • Only show it if:
    • The build is using Node 16
      • But isn't explicitly specifying Node 16 (we don't need to bother people who are specifying it, because they can continue to do so)
  • The banner should change on November 27 when we roll out the change to everyone

@@ -63,6 +63,7 @@ export async function collectMetadataAsync<T extends Platform>(
customWorkflowName: ctx.customBuildConfigMetadata?.workflowName,
developmentClient: ctx.developmentClient,
requiredPackageManager: ctx.requiredPackageManager ?? undefined,
selectedImage: ctx.buildProfile.image,
};
return sanitizeMetadata(metadata);
Copy link
Contributor

@sjchmiela sjchmiela Nov 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right, thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

github-actions bot commented Nov 8, 2023

Size Change: -289 kB (-1%)

Total Size: 42.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.3 MB -289 kB (-1%)

compressed-size-action

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #2113 (0a84ad1) into main (f8cfa00) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0a84ad1 differs from pull request most recent head 75a20f2. Consider uploading reports for the commit 75a20f2 to get more accurate results

@@            Coverage Diff             @@
##             main    #2113      +/-   ##
==========================================
+ Coverage   54.19%   54.19%   +0.01%     
==========================================
  Files         509      509              
  Lines       18656    18657       +1     
  Branches     3936     3739     -197     
==========================================
+ Hits        10109    10110       +1     
- Misses       7860     8526     +666     
+ Partials      687       21     -666     
Files Coverage Δ
packages/eas-cli/src/build/metadata.ts 21.35% <ø> (ø)
packages/eas-cli/src/graphql/generated.ts 100.00% <100.00%> (ø)

... and 190 files with indirect coverage changes

@szdziedzic
Copy link
Member Author

/changelog-entry chore Add selectedImage and customNodeVersion information to build metadata

Copy link

github-actions bot commented Nov 8, 2023

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic changed the title [ENG-10566][eas-cli] add selectedImage to build metadata [ENG-10566][eas-cli] add selectedImage and customNodeVersion to build metadata Nov 8, 2023
@szdziedzic szdziedzic requested a review from sjchmiela November 8, 2023 11:23
@szdziedzic szdziedzic merged commit 9f4e39b into main Nov 8, 2023
6 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/add-selected-image-ro-build-metadata branch November 8, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants