Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Add link to SDK upgrade page for SDK-gated command error #2106

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

wschurman
Copy link
Member

Why

See expo/expo#25146 for context. We want to link to that page to instruct people how to upgrade in order to get this feature. Note that it is still in alpha.

How

Add link.

Test Plan

Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction.

@wschurman wschurman requested review from quinlanj and brentvatne and removed request for szdziedzic and khamilowicz October 31, 2023 21:06
@wschurman
Copy link
Member Author

/changelog-entry chore Add link to SDK upgrade page for SDK-gated command error

Copy link

✅ Thank you for adding the changelog entry!

Copy link

github-actions bot commented Oct 31, 2023

Size Change: -870 B (0%)

Total Size: 42.6 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.6 MB -870 B (0%)

compressed-size-action

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #2106 (3bc46ab) into main (2600805) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2106   +/-   ##
=======================================
  Coverage   54.19%   54.19%           
=======================================
  Files         509      509           
  Lines       18656    18656           
  Branches     3936     3936           
=======================================
  Hits        10109    10109           
  Misses       7860     7860           
  Partials      687      687           
Files Coverage Δ
packages/eas-cli/src/project/projectUtils.ts 56.48% <100.00%> (ø)

@wschurman wschurman merged commit f8cfa00 into main Oct 31, 2023
9 checks passed
@wschurman wschurman deleted the @wschurman/add-more-info-to-error branch October 31, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants