[eas-cli][eas-json] remove Intel resource class related code #2093
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2093 +/- ##
==========================================
+ Coverage 54.05% 54.14% +0.10%
==========================================
Files 509 509
Lines 18665 18624 -41
Branches 3935 3922 -13
==========================================
- Hits 10088 10083 -5
+ Misses 7886 7854 -32
+ Partials 691 687 -4
|
| /** | ||
| * @deprecated use M_MEDIUM instead | ||
| */ | ||
| M1_EXPERIMENTAL = 'm1-experimental', | ||
| /** | ||
| * @deprecated use M_MEDIUM instead | ||
| */ | ||
| M1_MEDIUM = 'm1-medium', |
There was a problem hiding this comment.
How about… you know what I'm thinking?
There was a problem hiding this comment.
Hmm, I think that we can't simply remove it, because when we originally introduced the M1 resource class, the way to use it was to set m1-medium in their eas.json (currently we recommend m-medium so you don't have to distinguish between M1, M2 and so on). That's why many people still have this value in their eas.json to this day. If we remove it, this change will break their builds.
I mean it's been deprecated for a while and we are printing a deprecation warning if you use it. So maybe we can do it? I don't know, it's a hard call. What do you think?
There was a problem hiding this comment.
I wouldn't remove it (yet), unless that CLI warning includes a 'do you want us to update your eas.json for you' step.
|
Size Change: -1.16 kB (0%) Total Size: 42.6 MB
|
szdziedzic
force-pushed
the
@szdziedzic/remove-intel-related-code
branch
from
5f4912f to
539d161
Compare
|
/changelog-entry chore Clean up Intel resource classes code after their deletion |
|
✅ Thank you for adding the changelog entry! |
Why
We no longer have Intel Macs in our fleet.
How
Clean up Intel resource class related code
Test Plan
Tests, test manually