feat: add tap to pay on iphone entitlement #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
reviewed
Sep 28, 2023
| { | ||
| entitlement: 'com.apple.developer.proximity-reader.payment.acceptance', | ||
| name: 'Tap to Pay on iPhone', | ||
| capability: 'TAP_TO_PAY_ON_IPHONE' as CapabilityType, |
There was a problem hiding this comment.
I've published @expo/[email protected] with TAP_TO_PAY_ON_IPHONE, SUSTAINED_EXECUTION, and NETWORK_SLICING.
There was a problem hiding this comment.
Thank you! The PR is updated to reflect this change.
brentvatne
approved these changes
Sep 28, 2023
Codecov Report
@@ Coverage Diff @@
## main #2069 +/- ##
========================================
Coverage 54.07% 54.07%
========================================
Files 508 508
Lines 18638 18638
Branches 3909 3721 -188
========================================
Hits 10076 10076
- Misses 7872 8542 +670
+ Partials 690 20 -670
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Seems like it's missing - but not sure if that was intentional or there's any other hindrance to it?
How
Add the entitlement object exactly like the others. It doesn't seem like there's anything else to do?
Test Plan
@EvanBacon It seems
@expo/apple-utilsis a private package, so I cannot contribute a change to add aTAP_TO_PAY_ON_IPHONEconstant for theCapabilityType- for now I just force casted this to keep TS happy.Thoughts?