feat(eas-cli): expose expo export dev flag as an option in eas update #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderscore
requested review from
EvanBacon,
byCedric,
wschurman,
szdziedzic and
khamilowicz
as code owners
nderscore
commented
Sep 7, 2023
| @@ -208,6 +210,7 @@ export async function buildBundlesAsync({ | |||
| '--dump-sourcemap', | |||
| '--dump-assetmap', | |||
| `--platform=${platformFlag}`, | |||
| ...(dev ? ['--dev'] : []), | |||
There was a problem hiding this comment.
I'm not sure if this flag exists on the legacy Expo CLI
There was a problem hiding this comment.
wschurman
requested review from
quinlanj
and removed request for
byCedric,
khamilowicz and
szdziedzic
douglowder
approved these changes
Sep 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #2050 +/- ##
==========================================
- Coverage 53.98% 53.97% -0.01%
==========================================
Files 508 508
Lines 18593 18600 +7
Branches 3909 3915 +6
==========================================
+ Hits 10036 10037 +1
- Misses 8537 8543 +6
Partials 20 20
|
quinlanj
approved these changes
Sep 12, 2023
| @@ -208,6 +210,7 @@ export async function buildBundlesAsync({ | |||
| '--dump-sourcemap', | |||
| '--dump-assetmap', | |||
| `--platform=${platformFlag}`, | |||
| ...(dev ? ['--dev'] : []), | |||
There was a problem hiding this comment.
Co-authored-by: Quinlan Jung <[email protected]>
|
@nderscore - can you manually add an entry to https://github.com/expo/eas-cli/blob/main/CHANGELOG.md Then we can go ahead an merge! |
|
@wschurman sorry for missing that part of the contributing docs! 😅 Updated with a change log entry. |
|
Thanks for the contribution! |
This was referenced Feb 6, 2024
wschurman
added a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When
__DEV__is unset orfalse, expo-dev-menu'sregisterDevMenuItemsoption is a no-op.In order to be able to use custom expo-dev-menu menu items in updates/previews for a debug build, it is necessary for the
__DEV__global variable to be set totruein the generated updates and preview bundles.EAS does not currently expose the
--devoption from Expo CLI'sexportcommand, which is what determines whether or not__DEV__gets stripped during bundling.How
Adds a new CLI flag (
--dev) to theeas updatecommand.When set, an additional CLI argument
--devis passed toexpo export.Test Plan
I tested this in my own project and it successfully deployed an update where
__DEV__is set to true and my custom dev menu items are being registered correctly.