[eas-cli] [ENG-9175] Update oclif version #2008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated oclif version See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Updated dependencies of cli that also use oclif and used to depend on older versions See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
…-9175-update-oclif-version # Conflicts: # yarn.lock
Updated the branch after long inactivity See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags for build command See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags for build:version:set and build:version:get commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Added getters for build status and distribution type from string flag values See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed args in `branch` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags in `build:version` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags and args in `build` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags and args in `channel` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags and args in `device` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags and args in `secret` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags and args in `update` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags and args in `webhook` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed flags and args in `analytics`, `config`, `credentials` and `submit` commands See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Fixed EasCommand-test See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Added getters for environment secret scope and secret type from string flag value See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Added getters for end outcome from string flag value See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Added getters for requested platform from string flag value See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
|
Size Change: +13.2 MB (+31%) 🚨 Total Size: 55.5 MB
|
Use newest version of oclif packages where possible See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Oclif v4 needs node >= v18, so had to downgrade it to v3 See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
This reverts commit 74f6f06.
This reverts commit bdfcd6c.
This reverts commit ab634e4.
This reverts commit 0683110.
This reverts commit c057738.
This reverts commit 5d4f380.
This reverts commit a32ee86.
This reverts commit 8e46cfc.
This reverts commit 00d3322.
This reverts commit 26af526.
This reverts commit d091288.
This reverts commit 669b212.
This reverts commit f24e7e5.
This reverts commit 766d48e.
This reverts commit 928d826.
This reverts commit f9d8e24.
Oclif v4 and v3 need node >= v18, so had to downgrade it to v2. v2 has a bug however when importing one of the dependencies which makes it unusable so had to go back to v1 See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
oclif/plugin-autocomplete v3 needs oclif/core v3 which needs node >= v18, so had to downgrade it to v2 See: https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2008 +/- ##
=======================================
Coverage 54.18% 54.18%
=======================================
Files 509 509
Lines 18662 18662
Branches 3742 3742
=======================================
Hits 10110 10110
Misses 8531 8531
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
/changelog-entry chore Update oclif dependencies |
radoslawkrzemien
requested review from
szdziedzic and
khamilowicz
as code owners
|
✅ Thank you for adding the changelog entry! |
|
TL:DR I had to abandon upgrading |
sjchmiela
approved these changes
Dec 1, 2023
| "@expo/prebuild-config": "6.2.5", | ||
| "@expo/results": "1.0.0", | ||
| "@expo/rudder-sdk-node": "1.1.1", | ||
| "@expo/spawn-async": "1.7.0", | ||
| "@expo/steps": "1.0.51", | ||
| "@expo/timeago.js": "1.0.0", | ||
| "@oclif/core": "1.23.2", | ||
| "@oclif/plugin-autocomplete": "1.3.10", | ||
| "@oclif/core": "^1.26.2", |
There was a problem hiding this comment.
Do we want to switch to ^ versions from strict versions?
There was a problem hiding this comment.
I don't see the harm in that, v1 is no longer developed anyway afaik (again, current is v4)
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-9175-update-oclif-version
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-9175/update-oclif-in-eas-cli
How
Updated versions of
oclifpackage, packages in@oclif/space (mostly those depending on deprecated@oclif/screenpackage, as well as dependencies that themselves useoclifand used to depend on older versionsTest Plan
Automated tests