Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] bump urql graphql client #1936

Merged
merged 3 commits into from
Jul 19, 2023
Merged

[eas-cli] bump urql graphql client #1936

merged 3 commits into from
Jul 19, 2023

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Jul 18, 2023

Why

Bump our major version of urql, our graphql client. It is more than 1 year outdated.

Major version migration

The release notes with major changes require some migration steps on our part.

  • dedupExchange: it has been deprecated and the functionality comes by default in the main urql Client. More details here
  • PromisifiedSource: replaced by OperationResultSource

Test Plan

  • manually tested some graphql heavy commands like eas credentials to check that everything is working normally

@quinlanj
Copy link
Member Author

/changelog-entry chore bump urql graphql client major version

@quinlanj quinlanj marked this pull request as ready for review July 18, 2023 17:56
@github-actions
Copy link

github-actions bot commented Jul 18, 2023

Size Change: +194 kB (0%)

Total Size: 42.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 42.1 MB +194 kB (0%)

compressed-size-action

@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #1936 (9ffd3a0) into main (57dd372) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
+ Coverage   52.56%   52.57%   +0.01%     
==========================================
  Files         479      479              
  Lines       17358    17361       +3     
  Branches     3473     3474       +1     
==========================================
+ Hits         9123     9125       +2     
- Misses       8218     8219       +1     
  Partials       17       17              
Impacted Files Coverage Δ
...dUtils/context/contextUtils/createGraphqlClient.ts 38.10% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for taking care of this update!

@quinlanj quinlanj merged commit fe57c05 into main Jul 19, 2023
@quinlanj quinlanj deleted the @quin/upgradeUrql branch July 19, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants