Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] add clear cache option to updates #1839

Merged
merged 2 commits into from
May 15, 2023
Merged

[eas-cli] add clear cache option to updates #1839

merged 2 commits into from
May 15, 2023

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented May 14, 2023

Why

The clear-cache option to remove the metro bundler cache exists for eas build and for the Classic Updates expo publish command, but it was overlooked for eas update. This PR adds the flag to eas update to bring it to parity with our other commands.

Fixes #1123 . Also a bunch of other users reported issues with eas update that I suspect would be fixed by clearing the metro bundler too.

How

eas update relies on the expo cli's expo export command to generate it's bundle. This PR plumbs down the clear-cache flag to the expo export command. This should work with all released versions of expo export since support for the clear flag has always existed.

Test Plan

  • tested manually eas update --clear-cache

@quinlanj
Copy link
Member Author

/changelog-entry new-feature add clear cache flag to eas update

@quinlanj quinlanj marked this pull request as ready for review May 14, 2023 22:10
@github-actions
Copy link

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj removed request for byCedric and wkozyra95 May 14, 2023 22:11
@github-actions
Copy link

github-actions bot commented May 14, 2023

Size Change: -2.26 kB (0%)

Total Size: 40.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 40.9 MB -2.26 kB (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Merging #1839 (b9207c4) into main (267fa0e) will decrease coverage by 0.00%.
The diff coverage is 33.34%.

@@            Coverage Diff             @@
##             main    #1839      +/-   ##
==========================================
- Coverage   52.90%   52.90%   -0.00%     
==========================================
  Files         475      475              
  Lines       17036    17038       +2     
  Branches     3404     3406       +2     
==========================================
  Hits         9012     9012              
- Misses       8005     8007       +2     
  Partials       19       19              
Impacted Files Coverage Δ
packages/eas-cli/src/project/publish.ts 80.30% <0.00%> (-0.60%) ⬇️
packages/eas-cli/src/commands/update/index.ts 75.45% <100.00%> (ø)

@quinlanj quinlanj merged commit c8e57f0 into main May 15, 2023
@quinlanj quinlanj deleted the @quin/clearCache branch May 15, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eas update missing --clear-cache option
3 participants