Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gha] add PR changelog check #1798

Merged
merged 2 commits into from
Apr 20, 2023
Merged

[gha] add PR changelog check #1798

merged 2 commits into from
Apr 20, 2023

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented Apr 19, 2023

Why

This PR implements my idea on how to make skipping adding the changelog entry less likely.

How

  • Add a workflow that fails if the PR didn't modify CHANGELOG.md.
  • The check is skipped if "no changelog" label is added to the PR.
  • Comment PR with the check status.

Test Plan

Screenshot 2023-04-19 at 15 58 42

Screenshot 2023-04-19 at 15 59 32

Screenshot 2023-04-19 at 16 00 04

@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Size Change: -424 B (0%)

Total Size: 40.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 40.9 MB -424 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Merging #1798 (19e0f1d) into main (da4b56a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1798   +/-   ##
=======================================
  Coverage   52.11%   52.11%           
=======================================
  Files         472      472           
  Lines       16798    16798           
  Branches     3524     3524           
=======================================
  Hits         8753     8753           
  Misses       7380     7380           
  Partials      665      665           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dsokal dsokal marked this pull request as ready for review April 19, 2023 12:06
@dsokal dsokal requested a review from wkozyra95 as a code owner April 19, 2023 12:06
@dsokal dsokal marked this pull request as draft April 19, 2023 12:06
@dsokal dsokal removed the request for review from wkozyra95 April 19, 2023 12:34
@dsokal dsokal added no changelog PR that doesn't require a changelog entry and removed no changelog PR that doesn't require a changelog entry labels Apr 19, 2023
@dsokal dsokal force-pushed the @dsokal/changelog branch from daea3b2 to ba64af1 Compare April 19, 2023 13:59
@dsokal dsokal added the no changelog PR that doesn't require a changelog entry label Apr 19, 2023
@dsokal dsokal force-pushed the @dsokal/changelog branch from ba64af1 to 9de15d8 Compare April 19, 2023 14:01
@dsokal dsokal changed the title @dsokal/changelog [gha] add PR changelog check Apr 19, 2023
@dsokal dsokal marked this pull request as ready for review April 19, 2023 14:07
@dsokal dsokal force-pushed the @dsokal/changelog branch from 9de15d8 to b4ce79f Compare April 19, 2023 14:16
@dsokal dsokal removed the no changelog PR that doesn't require a changelog entry label Apr 19, 2023
@dsokal dsokal force-pushed the @dsokal/changelog branch 2 times, most recently from 151a583 to 72f0e5b Compare April 19, 2023 14:22
@dsokal dsokal added the no changelog PR that doesn't require a changelog entry label Apr 19, 2023
@dsokal dsokal force-pushed the @dsokal/changelog branch from 72f0e5b to 19e0f1d Compare April 20, 2023 08:27
@github-actions
Copy link

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@dsokal dsokal merged commit 1bbe7df into main Apr 20, 2023
@dsokal dsokal deleted the @dsokal/changelog branch April 20, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants