refactor(update): remove republish from update command #1535

byCedric · 2022-11-21T16:22:22Z

Checklist

I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

Follow up of #1533, part of ENG-5926

How

Kept the --group and --republish flags in the command
Added warning with new command when using flags
Dropped all related code to republish from the update command

Test Plan

When using --group or --republish, users should now get a deprecation warning with the new command. This replacement command uses the --branch and --group flags, to help users just copy whatever they need.

github-actions · 2022-11-21T16:27:10Z

Size Change: +604 B (0%)

Total Size: 40.3 MB

Filename	Size	Change
`./packages/eas-cli/dist/eas-linux-x64.tar.gz`	40.3 MB	+604 B (0%)

_{compressed-size-action}

codecov · 2022-11-21T16:27:49Z

Codecov Report

Merging #1535 (6626f37) into main (33f4ae7) will increase coverage by 0.26%.
The diff coverage is 50.32%.

❗ Current head 6626f37 differs from pull request most recent head e00bd3e. Consider uploading reports for the commit e00bd3e to get more accurate results

@@            Coverage Diff             @@
##             main    #1535      +/-   ##
==========================================
+ Coverage   51.13%   51.38%   +0.26%     
==========================================
  Files         461      460       -1     
  Lines       16066    15973      -93     
  Branches     3175     3141      -34     
==========================================
- Hits         8213     8206       -7     
+ Misses       7838     7752      -86     
  Partials       15       15

Impacted Files	Coverage Δ
packages/eas-cli/src/commands/update/index.ts	`16.83% <0.00%> (+2.16%)`	⬆️
packages/eas-cli/src/graphql/generated.ts	`100.00% <ø> (ø)`
...ckages/eas-cli/src/graphql/queries/PublishQuery.ts	`23.08% <0.00%> (-10.25%)`	⬇️
packages/eas-cli/src/graphql/types/Update.ts	`100.00% <ø> (ø)`
packages/eas-cli/src/commands/update/republish.ts	`74.08% <74.08%> (ø)`
packages/eas-cli/src/commands/build/run.ts	`22.67% <0.00%> (-1.42%)`	⬇️
packages/eas-cli/src/build/runBuildAndSubmit.ts	`24.82% <0.00%> (-0.33%)`	⬇️
packages/eas-cli/src/devices/utils/formatDevice.ts	`68.19% <0.00%> (ø)`
packages/eas-cli/src/run/utils.ts
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

wschurman · 2022-11-23T17:24:48Z

packages/eas-cli/src/commands/update/index.ts

@@ -112,11 +109,11 @@ export default class UpdatePublish extends EasCommand {
      required: false,
    }),
    republish: Flags.boolean({
-      description: 'Republish an update group',
+      description: 'Republish an update group (deprecated, see republish command)',


Suggested change

description: 'Republish an update group (deprecated, see republish command)',

description: 'Republish an update group',

deprecated: true,

(or feel free to leave stuff in description and add deprecated field)

The deprecated feature from OCLIF is far from optimal. It produces a warning on every command invocation, even when not using the flag. Not a strong opinion, but I would advice against using the deprecated feature.

See aborted PR #1500 for an example

wschurman · 2022-11-23T17:24:55Z

packages/eas-cli/src/commands/update/index.ts

      exclusive: ['input-dir', 'skip-bundler'],
    }),
    group: Flags.string({
-      description: 'Update group to republish',
+      description: 'Update group to republish (deprecated, see republish command)',


See: #1535 (comment)

packages/eas-cli/src/commands/update/index.ts

byCedric · 2022-11-25T14:41:04Z

/changelog-entry chore Remove old republish code from the update command

dsokal · 2022-11-25T14:45:05Z

CHANGELOG.md

@@ -12,6 +12,8 @@ This is the log of notable changes to EAS CLI and related packages.

 ### 🧹 Chores

+- Remove old republish code from the update command. ([#1535](https://github.com/expo/eas-cli/pull/1535) by [@byCedric](https://github.com/byCedric))


Rebase and move to the correct group.

I reverted, rebased, merged conflicts, and recreated changelog entries for both #1533 and #1535.

byCedric · 2022-11-25T14:59:58Z

/changelog-entry chore Remove old republish code from the update command

…t branches

…changes

byCedric mentioned this pull request Nov 23, 2022

[eas-cli] Split republish command from update command #1533

Merged

1 task

byCedric marked this pull request as ready for review November 23, 2022 14:04

byCedric requested review from EvanBacon and wschurman as code owners November 23, 2022 14:04

wschurman requested changes Nov 23, 2022

View reviewed changes

byCedric force-pushed the @bycedric/update/clean-up-republish branch from bf0517f to deb311d Compare November 25, 2022 14:24

byCedric requested a review from wschurman November 25, 2022 14:41

github-actions bot requested review from dsokal and wkozyra95 as code owners November 25, 2022 14:41

dsokal reviewed Nov 25, 2022

View reviewed changes

byCedric force-pushed the @bycedric/update/split-republish branch from 0c7dcf4 to 5de5a9a Compare November 25, 2022 14:46

byCedric force-pushed the @bycedric/update/clean-up-republish branch from 08ece28 to 6626f37 Compare November 25, 2022 14:59

byCedric force-pushed the @bycedric/update/clean-up-republish branch from c33c9b4 to 8c48bfd Compare November 25, 2022 15:08

wschurman approved these changes Nov 28, 2022

View reviewed changes

wkozyra95 removed their request for review November 29, 2022 11:46

Base automatically changed from @bycedric/update/split-republish to main December 5, 2022 12:08

byCedric added 10 commits December 5, 2022 13:15

fix(update): add code signing support to republish and block differen…

b3c489a

…t branches

refactor(update): move codesigning info into update fragment

2acd789

update CHANGELOG.md

53688b9

fix(update): add code signing support to republish and block differen…

45120ea

…t branches

refactor(update): mark group and republish flags as deprecated

38c7884

refactor(update): drop republish and group flags

f345634

refactor(update): drop republish flag from command

66e057a

refactor(update): remove last republish code from update command

5a40d3c

refactor(update): either use --group or --branch in deprecation warning

c9e1842

refactor(update): drop old runtime version from update command

6c0d740

byCedric added 3 commits December 5, 2022 13:19

refactor(update): move asset variables closer to populated area

8efdf56

fix(update): fix republish typo in deprecation warning

a9f87af

fix(update): correct a merge conflict error related to publish query …

e00bd3e

…changes

byCedric force-pushed the @bycedric/update/clean-up-republish branch from 8c48bfd to e00bd3e Compare December 5, 2022 12:20

byCedric merged commit 4e11707 into main Dec 5, 2022

byCedric deleted the @bycedric/update/clean-up-republish branch December 5, 2022 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(update): remove republish from update command #1535

refactor(update): remove republish from update command #1535

byCedric commented Nov 21, 2022 •

edited

Loading

github-actions bot commented Nov 21, 2022 •

edited

Loading

codecov bot commented Nov 21, 2022 •

edited

Loading

wschurman Nov 23, 2022

byCedric Nov 25, 2022 •

edited

Loading

wschurman Nov 23, 2022

byCedric Nov 25, 2022

byCedric commented Nov 25, 2022

dsokal Nov 25, 2022

byCedric Nov 25, 2022

byCedric commented Nov 25, 2022

	description: 'Republish an update group (deprecated, see republish command)',
	description: 'Republish an update group',
	deprecated: true,

		@@ -12,6 +12,8 @@ This is the log of notable changes to EAS CLI and related packages.

		### 🧹 Chores

		- Remove old republish code from the update command. ([#1535](https://github.com/expo/eas-cli/pull/1535) by [@byCedric](https://github.com/byCedric))

refactor(update): remove republish from update command #1535

refactor(update): remove republish from update command #1535

Conversation

byCedric commented Nov 21, 2022 • edited Loading

Checklist

Why

How

Test Plan

github-actions bot commented Nov 21, 2022 • edited Loading

codecov bot commented Nov 21, 2022 • edited Loading

Codecov Report

wschurman Nov 23, 2022

Choose a reason for hiding this comment

byCedric Nov 25, 2022 • edited Loading

Choose a reason for hiding this comment

wschurman Nov 23, 2022

Choose a reason for hiding this comment

byCedric Nov 25, 2022

Choose a reason for hiding this comment

byCedric commented Nov 25, 2022

dsokal Nov 25, 2022

Choose a reason for hiding this comment

byCedric Nov 25, 2022

Choose a reason for hiding this comment

byCedric commented Nov 25, 2022

byCedric commented Nov 21, 2022 •

edited

Loading

github-actions bot commented Nov 21, 2022 •

edited

Loading

codecov bot commented Nov 21, 2022 •

edited

Loading

byCedric Nov 25, 2022 •

edited

Loading