Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] remove install script #1280

Merged
merged 2 commits into from
Aug 16, 2022
Merged

[eas-cli] remove install script #1280

merged 2 commits into from
Aug 16, 2022

Conversation

wkozyra95
Copy link
Contributor

@wkozyra95 wkozyra95 commented Aug 16, 2022

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

https://linear.app/expo/issue/ENG-6051/figure-out-what-to-do-with-installer-scripts#comment-01ebea8f

How

Remove install script and gh workflow that tests it.

Test Plan

Installer was not used for anything, so there is nothing to test.

@wkozyra95 wkozyra95 requested a review from dsokal as a code owner August 16, 2022 10:11
@wkozyra95
Copy link
Contributor Author

/changelog-entry chore Remove unused install script.

@wkozyra95 wkozyra95 changed the title [eas-cli] remove installer [eas-cli] remove install script Aug 16, 2022
@github-actions
Copy link

Size Change: -1.27 kB (0%)

Total Size: 40.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 40.9 MB -1.27 kB (0%)

compressed-size-action

Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wkozyra95 wkozyra95 merged commit 3986e2f into main Aug 16, 2022
@wkozyra95 wkozyra95 deleted the @wkozyra95/remove-installer branch August 16, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants