Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Temporarily increase coverage memory to stabilize CI #1196

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Jul 4, 2022

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

CI's coverage tests seem to fail due to OOM errors caused by OCLIF. This (temporarily) increases the memory limit to stabilize CI more. But, eventually, we have to address these OOM errors (see this notion doc)

How

Added NODE_OPTIONS envvar to the yarn test --coverage command.

Test Plan

See if CI is more stable than it currently is.

@byCedric byCedric requested review from dsokal and wkozyra95 as code owners July 4, 2022 15:18
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Size Change: -344 B (0%)

Total Size: 25.1 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 25.1 MB -344 B (0%)

compressed-size-action

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #1196 (4be7ceb) into main (d3d6d41) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1196   +/-   ##
=======================================
  Coverage   51.43%   51.43%           
=======================================
  Files         373      373           
  Lines       13358    13358           
  Branches     2752     2752           
=======================================
  Hits         6870     6870           
  Misses       5974     5974           
  Partials      514      514           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bce9b1...4be7ceb. Read the comment docs.

@byCedric byCedric merged commit 7487f41 into main Jul 11, 2022
@byCedric byCedric deleted the @bycedric/ci/increase-memory-coverage branch July 11, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants