Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for node <14 #1098

Merged
merged 4 commits into from
May 19, 2022
Merged

Drop support for node <14 #1098

merged 4 commits into from
May 19, 2022

Conversation

dsokal
Copy link
Contributor

@dsokal dsokal commented May 11, 2022

Checklist

  • I've added an entry to CHANGELOG.md if necessary. You can comment this pull request with /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message] and CHANGELOG.md will be updated automatically.

Why

How

  • Drop support for Node 12 and 13.
  • Run CI jobs on Node 18.
  • Update node and yarn in volta config.
  • Upgrade memfs to the latest (previous version does not work with Node 18).

Test Plan

CI

@dsokal dsokal force-pushed the @dsokal/update-node branch from c7ae998 to 3bb677e Compare May 11, 2022 09:27
@github-actions
Copy link

github-actions bot commented May 11, 2022

Size Change: -876 B (0%)

Total Size: 25.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 25.4 MB -876 B (0%)

compressed-size-action

@dsokal dsokal force-pushed the @dsokal/update-node branch from 3bb677e to f4678ea Compare May 18, 2022 07:41
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1098 (e18fbca) into main (607838c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1098   +/-   ##
=======================================
  Coverage   50.24%   50.24%           
=======================================
  Files         346      346           
  Lines       12719    12719           
  Branches     2589     2589           
=======================================
  Hits         6389     6389           
  Misses       5819     5819           
  Partials      511      511           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 607838c...e18fbca. Read the comment docs.

@dsokal dsokal marked this pull request as ready for review May 18, 2022 07:48
@dsokal dsokal requested a review from wkozyra95 as a code owner May 18, 2022 07:48
@dsokal dsokal requested review from kbrandwijk and brentvatne May 18, 2022 07:48
@dsokal dsokal force-pushed the @dsokal/update-node branch from f4678ea to e18fbca Compare May 18, 2022 07:49
@dsokal
Copy link
Contributor Author

dsokal commented May 18, 2022

@brentvatne @kbrandwijk Do you think we can safely "just release" this change or we should rather communicate it somehow?
On one hand, it can break people's workflows if they use Node 12 in CI and install EAS CLI like yarn add eas-cli (no version specified). On the other hand, people should avoid installing non-pinned versions of CLI tools.
I'm leaning towards just releasing it without any prior announcement.

Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to do any additional communication here - we already said in our release notes for sdk 45 that node 12 is no longer supported, and node 13 wasn't in LTS and therefore not supported.

@brentvatne
Copy link
Member

brentvatne commented May 18, 2022

although - what will the failure mode be here if users are on node 12? ideally we'd let people know that their node version is incompatible when running any cli command.

we do this in expo-cli here: https://github.com/expo/expo-cli/blob/main/packages/expo-cli/bin/expo.js (this is slightly out of date, given that expo-cli is primarily in maintenance mode as we migrate towards local cli)

@dsokal
Copy link
Contributor Author

dsokal commented May 19, 2022

AFAIK if you set the engines field in package.json then the failure mode is that npm/yarn just won't let you install the package 🙃

@dsokal dsokal merged commit f0c958e into main May 19, 2022
@dsokal dsokal deleted the @dsokal/update-node branch May 19, 2022 08:21
@brentvatne
Copy link
Member

AFAIK if you set the engines field in package.json then the failure mode is that npm/yarn just won't let you install the package 🙃

haha true. in the case of expo-cli we also cared about making it clear to people that we may not support the latest version yet and wanted to provide some context in the message about it - since you can't control the message if you use engines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants