-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for node <14 #1098
Conversation
c7ae998
to
3bb677e
Compare
Size Change: -876 B (0%) Total Size: 25.4 MB
|
3bb677e
to
f4678ea
Compare
Codecov Report
@@ Coverage Diff @@
## main #1098 +/- ##
=======================================
Coverage 50.24% 50.24%
=======================================
Files 346 346
Lines 12719 12719
Branches 2589 2589
=======================================
Hits 6389 6389
Misses 5819 5819
Partials 511 511 Continue to review full report at Codecov.
|
f4678ea
to
e18fbca
Compare
@brentvatne @kbrandwijk Do you think we can safely "just release" this change or we should rather communicate it somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to do any additional communication here - we already said in our release notes for sdk 45 that node 12 is no longer supported, and node 13 wasn't in LTS and therefore not supported.
although - what will the failure mode be here if users are on node 12? ideally we'd let people know that their node version is incompatible when running any cli command. we do this in expo-cli here: https://github.com/expo/expo-cli/blob/main/packages/expo-cli/bin/expo.js (this is slightly out of date, given that expo-cli is primarily in maintenance mode as we migrate towards local cli) |
AFAIK if you set the |
haha true. in the case of expo-cli we also cared about making it clear to people that we may not support the latest version yet and wanted to provide some context in the message about it - since you can't control the message if you use |
Checklist
/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]
and CHANGELOG.md will be updated automatically.Why
How
memfs
to the latest (previous version does not work with Node 18).Test Plan
CI