Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Use new expo-updates configuration:syncnative for versioned native sync #2269

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Mar 7, 2024

Why

This makes use of the new command added in expo/expo#27511 to ensure that the runtime version resolution and synchronization are both versioned.

How

Call the CLI instead of using the version of config plugins depended on by eas-cli when possible.

Test Plan

In a generic project using fingerprint and requireCommit: true:

yarn link expo-updates
neas build -p android

and ensure the native sync is no longer the old version (meaning it called the CLI to do the native sync).

… native sync
@wschurman wschurman changed the title [eas-cli] Use new expo-updates configuration:syncnative for versioned… [eas-cli] Use new expo-updates configuration:syncnative for versioned native sync Mar 7, 2024
@wschurman wschurman requested review from quinlanj and douglowder and removed request for byCedric and EvanBacon March 7, 2024 23:43
Copy link

github-actions bot commented Mar 7, 2024

Size Change: -4.57 kB (0%)

Total Size: 51.3 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 51.3 MB -4.57 kB (0%)

compressed-size-action

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 54.01%. Comparing base (d78917b) to head (fc4de56).

Files Patch % Lines
...ckages/eas-cli/src/update/android/UpdatesModule.ts 40.00% 3 Missing ⚠️
packages/eas-cli/src/update/ios/UpdatesModule.ts 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2269      +/-   ##
==========================================
- Coverage   54.02%   54.01%   -0.00%     
==========================================
  Files         520      520              
  Lines       18961    18971      +10     
  Branches     3805     3807       +2     
==========================================
+ Hits        10242    10246       +4     
- Misses       8698     8704       +6     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wschurman
Copy link
Member Author

/changelog-entry new-feature Use new expo-updates configuration:syncnative for versioned native sync

Copy link

github-actions bot commented Mar 8, 2024

✅ Thank you for adding the changelog entry!

@wschurman wschurman merged commit ef6623c into main Mar 8, 2024
9 checks passed
@wschurman wschurman deleted the @wschurman/use-new-sync-command branch March 8, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants