[eas-cli] [ENG-11247] Remove duplicate log #2208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Information about App Store Connect API key being created was displayed twice to the user. This removes the duplicate See: https://linear.app/expo/issue/ENG-11247/fix-console-output-when-creating-asc-key
radoslawkrzemien
requested review from
szdziedzic,
khamilowicz and
sjchmiela
as code owners
|
Size Change: +2.11 kB (0%) Total Size: 51.5 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2208 +/- ##
==========================================
- Coverage 54.16% 54.16% -0.00%
==========================================
Files 516 516
Lines 18808 18805 -3
Branches 3772 3968 +196
==========================================
- Hits 10186 10183 -3
+ Misses 8601 7931 -670
- Partials 21 691 +670 ☔ View full report in Codecov by Sentry. |
szdziedzic
approved these changes
Feb 1, 2024
|
/changelog-entry chore Remove duplicated log message when creating ASC API key |
|
✅ Thank you for adding the changelog entry! |
radoslawkrzemien
deleted the
@radoslawkrzemien/ENG-11247-fix-console-output-for-creating-asc-keys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
https://linear.app/expo/issue/ENG-11247/fix-console-output-when-creating-asc-key
How
Information about App Store Connect API key being created was displayed twice to the user. This removes the duplicate
Test Plan
Tested manually
Screens
Before
After