Skip to content

Commit

Permalink
[eas-cli] [ENG-11247] Remove duplicate log (#2208)
Browse files Browse the repository at this point in the history
* [eas-cli] Remove duplicate log

Information about App Store Connect API key being created was displayed twice to the user. This removes the duplicate

See: https://linear.app/expo/issue/ENG-11247/fix-console-output-when-creating-asc-key

* update CHANGELOG.md
  • Loading branch information
radoslawkrzemien authored Feb 1, 2024
1 parent a6e281b commit 204a8b7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ This is the log of notable changes to EAS CLI and related packages.

### 🧹 Chores

- Remove duplicated log message when creating ASC API key. ([#2208](https://github.com/expo/eas-cli/pull/2208) by [@radoslawkrzemien](https://github.com/radoslawkrzemien))

## [7.1.2](https://github.com/expo/eas-cli/releases/tag/v7.1.2) - 2024-01-30

### 🧹 Chores
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { AppStoreApiKeyPurpose, provideOrGenerateAscApiKeyAsync } from './AscApiKeyUtils';
import { AccountFragment, AppStoreConnectApiKeyFragment } from '../../../graphql/generated';
import Log from '../../../log';
import { CredentialsContext } from '../../context';

export class CreateAscApiKey {
Expand All @@ -15,8 +14,6 @@ export class CreateAscApiKey {
}

const ascApiKey = await provideOrGenerateAscApiKeyAsync(ctx, purpose);
const result = await ctx.ios.createAscApiKeyAsync(ctx.graphqlClient, this.account, ascApiKey);
Log.succeed('Created App Store Connect API Key');
return result;
return await ctx.ios.createAscApiKeyAsync(ctx.graphqlClient, this.account, ascApiKey);
}
}

0 comments on commit 204a8b7

Please sign in to comment.