Skip to content

Commit

Permalink
use better warn message for Xcode < 14 images and link to our changel…
Browse files Browse the repository at this point in the history 
…og post
  • Loading branch information
@szdziedzic
szdziedzic committed Mar 29, 2024
1 parent 59c7211 commit a559e90
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 13 deletions.
25 changes: 22 additions & 3 deletions packages/eas-cli/src/build/runBuildAndSubmit.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,6 @@ export async function runBuildAndSubmitAsync(
'ubuntu-20.04-jdk-8-ndk-r21e',
'ubuntu-20.04-jdk-11-ndk-r19c',
'ubuntu-20.04-jdk-8-ndk-r19c',
'macos-monterey-12.4-xcode-13.4',
'macos-monterey-12.3-xcode-13.3',
'macos-monterey-12.1-xcode-13.2',
].includes(buildProfile.profile.image)
) {
Log.warn(
Expand All @@ -157,6 +154,28 @@ export async function runBuildAndSubmitAsync(
)}`
);
}

if (
buildProfile.profile.image &&
[
'macos-monterey-12.4-xcode-13.4',
'macos-monterey-12.3-xcode-13.3',
'macos-monterey-12.1-xcode-13.2',
'macos-ventura-13.4-xcode-14.3.1',
'macos-ventura-13.3-xcode-14.3',
'macos-monterey-12.6-xcode-14.2',
'macos-monterey-12.6-xcode-14.1',
'macos-monterey-12.6-xcode-14.0',
].includes(buildProfile.profile.image)
) {
Log.warn(
`The "image" field in the build profile "${buildProfile.profileName}" is set to "${
buildProfile.profile.image
}". This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting macos-ventura-13.6-xcode-15.2 or latest as your image value. This image will be removed from EAS Build on May 29th, 2024. ${learnMore(
'https://expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates'
)}`
);
}
}

await ensureExpoDevClientInstalledForDevClientBuildsAsync({
Expand Down
25 changes: 15 additions & 10 deletions packages/eas-json/schema/eas.schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -383,12 +383,7 @@
"`sdk-49`",
"macos-ventura-13.6-xcode-15.2",
"macos-ventura-13.6-xcode-15.1",
"macos-ventura-13.6-xcode-15.0",
"macos-ventura-13.4-xcode-14.3.1",
"macos-ventura-13.3-xcode-14.3",
"macos-monterey-12.6-xcode-14.2",
"macos-monterey-12.6-xcode-14.1",
"macos-monterey-12.6-xcode-14.0"
"macos-ventura-13.6-xcode-15.0"
],
"markdownEnumDescriptions": [
"When using this option the build image is selected automatically based on the project configuration, detected Expo SDK and React Native versions.",
Expand All @@ -404,14 +399,24 @@
"stable",
"macos-monterey-12.4-xcode-13.4",
"macos-monterey-12.3-xcode-13.3",
"macos-monterey-12.1-xcode-13.2"
"macos-monterey-12.1-xcode-13.2",
"macos-ventura-13.4-xcode-14.3.1",
"macos-ventura-13.3-xcode-14.3",
"macos-monterey-12.6-xcode-14.2",
"macos-monterey-12.6-xcode-14.1",
"macos-monterey-12.6-xcode-14.0"
],
"markdownEnumDescriptions": [
"This image tag is deprecated, please use other image tags or images directly instead.",
"This image tag is deprecated, please use other image tags or images directly instead.",
"This image is deprecated, please use one of the more recent images instead.",
"This image is deprecated, please use one of the more recent images instead.",
"This image is deprecated, please use one of the more recent images instead."
"This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates.",
"This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates.",
"This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates.",
"This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates.",
"This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates.",
"This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates.",
"This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates.",
"This image is using Xcode in version lower then 15. Apple's new requirement states that starting on April 29th, 2024, apps uploaded to App Store Connect must be built with Xcode 15 for iOS 17, iPadOS 17, tvOS 17, or watchOS 10. Start using Xcode 15 image today by setting `macos-ventura-13.6-xcode-15.2` or `latest` as your image value. This image will be removed from EAS Build on May 29th, 2024. Learn more: expo.dev/changelog/2024/03-29-eas-build-upcoming-ios-images-updates."
]
}
]
Expand Down

0 comments on commit a559e90

Please sign in to comment.