Merge branch 'main' into jon/eng-7125-only-add-channels-to-build-prof…

…iles-when
expo · Jan 3, 2023 · 26dcf67 · 26dcf67
2 parents 37bdbe8 + 9245657
commit 26dcf67
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,10 +9,12 @@ This is the log of notable changes to EAS CLI and related packages.
 ### 🎉 New features
 
 - Add `--channel` option to `update:republish`. ([#1580](https://github.com/expo/eas-cli/pull/1580) by [@byCedric](https://github.com/byCedric))
+- Use `appVersion` as default runtime version policy when running `eas update:configure`. ([#1588](https://github.com/expo/eas-cli/pull/1588) by [@jonsamp](https://github.com/jonsamp))
 
 ### 🐛 Bug fixes
 
 - Makes eas.json configuration to only run on `update:configure`. ([#1598](https://github.com/expo/eas-cli/pull/1598) by [@jonsamp](https://github.com/jonsamp))
+- Fix issue with invisible build info in some terminals in the `eas build:run` and `eas build:resign` commands. ([#1602](https://github.com/expo/eas-cli/pull/1602) by [@szdziedzic](https://github.com/szdziedzic))
 
 ### 🧹 Chores
 

diff --git a/packages/eas-cli/src/build/queries.ts b/packages/eas-cli/src/build/queries.ts
@@ -95,7 +95,7 @@ export async function listAndSelectBuildOnAppAsync(
 }
 
 function formatBuildChoiceValue(value: string | undefined | null): string {
-  return value ? chalk.bold(value) : chalk.dim('Unknown');
+  return value ? chalk.bold(value) : 'Unknown';
 }
 
 function formatBuildChoiceTitleAndDescription(build: BuildFragment): {
@@ -105,19 +105,21 @@ function formatBuildChoiceTitleAndDescription(build: BuildFragment): {
   const splitCommitMessage = build.gitCommitMessage?.split('\n');
   const formattedCommitData =
     build.gitCommitHash && splitCommitMessage && splitCommitMessage.length > 0
-      ? `${chalk.dim(build.gitCommitHash.slice(0, 7))} "${chalk.bold(
+      ? `${build.gitCommitHash.slice(0, 7)} "${chalk.bold(
           splitCommitMessage[0] + (splitCommitMessage.length > 1 ? '…' : '')
         )}"`
       : 'Unknown';
 
   return {
-    title: `ID: ${chalk.dim(build.id)} (${chalk.dim(`${fromNow(new Date(build.updatedAt))} ago`)})`,
+    title: `${chalk.bold(`ID:`)} ${build.id} (${chalk.bold(
+      `${fromNow(new Date(build.updatedAt))} ago`
+    )})`,
     description: [
-      `\tVersion: ${formatBuildChoiceValue(build.appVersion)}`,
-      `\t${
-        build.platform === AppPlatform.Ios ? 'Build number' : 'Version code'
-      }: ${formatBuildChoiceValue(build.appBuildVersion)}`,
-      `\tCommit: ${formattedCommitData}`,
+      `\t${chalk.bold(`Version:`)} ${formatBuildChoiceValue(build.appVersion)}`,
+      `\t${chalk.bold(
+        build.platform === AppPlatform.Ios ? 'Build number:' : 'Version code:'
+      )} ${formatBuildChoiceValue(build.appBuildVersion)}`,
+      `\t${chalk.bold(`Commit:`)} ${formattedCommitData}`,
     ].join('\n'),
   };
 }

diff --git a/packages/eas-cli/src/update/configure.ts b/packages/eas-cli/src/update/configure.ts
@@ -18,7 +18,7 @@ import { resolveWorkflowPerPlatformAsync } from '../project/workflow';
 import { syncUpdatesConfigurationAsync as syncAndroidUpdatesConfigurationAsync } from './android/UpdatesModule';
 import { syncUpdatesConfigurationAsync as syncIosUpdatesConfigurationAsync } from './ios/UpdatesModule';
 
-export const DEFAULT_MANAGED_RUNTIME_VERSION = { policy: 'sdkVersion' } as const;
+export const DEFAULT_MANAGED_RUNTIME_VERSION = { policy: 'appVersion' } as const;
 export const DEFAULT_BARE_RUNTIME_VERSION = '1.0.0' as const;
 
 function getDefaultRuntimeVersion(workflow: Workflow): NonNullable<ExpoConfig['runtimeVersion']> {