Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build-tools] run resolvePackageManager function in correct directory for custom builds #427

Conversation

szdziedzic
Copy link
Member

Why

expo/eas-cli#2401 (comment)

It seems like we are running resolvePackageManager in the wrong directory for custom builds (stepsCtx.global.projectTargetDirectory vs stepsCtx.workingDir).

For standard builds, we run resolvePackageManager in the ctx.getReactNativeProjectDirectory() directory

public get packageManager(): PackageManager {
return resolvePackageManager(this.getReactNativeProjectDirectory());
}

that is the default stepsCtx.workingDir for custom builds.

How

Run resolvePackageManager in stepsCtx.workingDir

Test Plan

Tests

@szdziedzic szdziedzic requested a review from khamilowicz July 22, 2024 10:20
@szdziedzic szdziedzic requested a review from sjchmiela as a code owner July 22, 2024 10:20
@szdziedzic szdziedzic merged commit 09fef9f into main Jul 22, 2024
4 checks passed
@szdziedzic szdziedzic deleted the @szdziedzic/fix-package-manager-resolution-logic-for-custom-builds branch July 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants