[build-tools] run resolvePackageManager
function in correct directory for custom builds
#427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo/eas-cli#2401 (comment)
It seems like we are running
resolvePackageManager
in the wrong directory for custom builds (stepsCtx.global.projectTargetDirectory
vsstepsCtx.workingDir
).For standard builds, we run
resolvePackageManager
in thectx.getReactNativeProjectDirectory()
directoryeas-build/packages/build-tools/src/context.ts
Lines 160 to 162 in b89f2dc
that is the default
stepsCtx.workingDir
for custom builds.How
Run
resolvePackageManager
instepsCtx.workingDir
Test Plan
Tests