Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eas-build-job] [ENG-12593] add fingerprint sources to metadata #421

Merged
merged 5 commits into from
Jun 25, 2024
Merged

[eas-build-job] [ENG-12593] add fingerprint sources to metadata #421

merged 5 commits into from
Jun 25, 2024

Conversation

kadikraman
Copy link
Contributor

@kadikraman kadikraman commented Jun 25, 2024 •
edited
Loading

@kadikraman kadikraman mentioned this pull request Jun 25, 2024
Merged
@kadikraman kadikraman changed the title [eas-build-job] add fingerprint sources to metadata [eas-build-job] [ENG-12593] add fingerprint sources to metadata Jun 25, 2024
@linear Linear
Copy link

linear bot commented Jun 25, 2024

ENG-12593 Add fingerprint sources to eas-build-job metadata

szdziedzic
szdziedzic requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, a few more small things

packages/eas-build-job/src/metadata.ts Outdated Show resolved Hide resolved
packages/eas-build-job/src/metadata.ts Outdated Show resolved Hide resolved
@kadikraman kadikraman requested a review from szdziedzic June 25, 2024 10:37
@kadikraman kadikraman requested a review from szdziedzic June 25, 2024 10:47
szdziedzic
szdziedzic approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@kadikraman kadikraman merged commit 5c14905 into main Jun 25, 2024
4 checks passed
@kadikraman kadikraman deleted the @kadikraman/fingerprint-source-metadata branch June 25, 2024 11:39
@kadikraman kadikraman mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szdziedzic szdziedzic szdziedzic approved these changes

@sjchmiela sjchmiela Awaiting requested review from sjchmiela sjchmiela is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kadikraman @szdziedzic