Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo from 'when' to 'went' #902

Merged
merged 1 commit into from
Apr 22, 2022
Merged

fix: typo from 'when' to 'went' #902

merged 1 commit into from
Apr 22, 2022

Conversation

srkds
Copy link
Contributor

@srkds srkds commented Feb 7, 2022

fixed typo in src/index.ts

- Something when wrong installing JavaScript dependencies. Check your ${packageManager} logs. Continuing to initialize the app.
+ Something went wrong installing JavaScript dependencies. Check your ${packageManager} logs. Continuing to initialize the app.

closes issue: #901

@EvanBacon EvanBacon merged commit 6616dac into expo:main Apr 22, 2022
@EvanBacon
Copy link
Contributor

@all-contributors add @srkds for code

@allcontributors allcontributors bot mentioned this pull request Apr 22, 2022
Merged
@allcontributors
Copy link
Contributor

@EvanBacon

I've put up a pull request to add @srkds! 🎉

@srkds
Copy link
Contributor Author

srkds commented Apr 23, 2022

Hi @EvanBacon 🎉Thank you for merging PR 🙌
And please close the issue #901

Thank you 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srkds @EvanBacon