Fix compilation with recent Cython 3.x versions #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of Cython 3.x refuse to compile the `_get_span2wp_alignment` function because it always requires acquiring the GIL to check if any exceptions are raised. Change the function signature to return an `int`, so that `-1` can be used to signal that an exception occured. It's not safe to qualify the function `noexcept`, since some calls can throw an exception.
svlandeg
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent versions of Cython 3.x refuse to compile the
_get_span2wp_alignmentfunction because it always requires acquiring the GIL to check if any exceptions are raised. Change the function signature to return anint, so that-1can be used to signal that an exception occured.It's not safe to qualify the function
noexcept, since some calls can throw an exception.Types of change
Bugfix
Checklist