Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code.module.sass to make code title sticky #13379

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update code.module.sass to make code title sticky #13379

merged 1 commit into from
Mar 26, 2024

Conversation

ynx0
Copy link
Contributor

@ynx0 ynx0 commented Mar 15, 2024 •
edited
Loading

Description

The filename / title for code listings scrolls along with the content, which may be undesirable. This PR makes the filename sticky. Tested on my machine.

Screenshot 2024-03-15 at 8 15 28 AM

Types of change

Style enhancement

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@ynx0 ynx0 marked this pull request as ready for review March 15, 2024 12:14
@svlandeg svlandeg added the docs Documentation and website label Mar 25, 2024
ines
ines approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@ines ines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks – this is a nice addition and looks good! 👍

@svlandeg svlandeg merged commit 21aea59 into explosion:master Mar 26, 2024
4 checks passed
svlandeg pushed a commit that referenced this pull request Mar 26, 2024
@ynx0 @svlandeg
Update code.module.sass to make code title sticky (#13379)
01a1bce
@ynx0 ynx0 deleted the patch-1 branch March 26, 2024 12:34
jordankanter pushed a commit to jordankanter/spaCy that referenced this pull request Mar 29, 2024
@ynx0 @jikanter
Update code.module.sass to make code title sticky (explosion#13379)
6e73136
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ines ines ines approved these changes

Assignees
No one assigned
Labels
docs Documentation and website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ynx0 @ines @svlandeg