Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Crosslingual Coreference to the spaCy universe #10572

Closed
wants to merge 0 commits into from
Closed

added Crosslingual Coreference to the spaCy universe #10572

wants to merge 0 commits into from

Conversation

davidberenstein1957
Copy link
Contributor

At Pandora Intelligence, I created another open-source package called crosslingual-coreference. It build upon some research hinting towards crosslingual training for coreference, xlm-models, and AllenNLP.

Description

I didn't test for all languages within the spaCy models, but it offers decent coref for at least Dutch, Danish and French, which aren't supported by Coreferee as of yet. On top of that, it is also performing well on English and German.

Types of change

documentation

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@davidberenstein1957
Copy link
Contributor Author

@svlandeg it was easier to create a new PR.

@svlandeg svlandeg added the docs Documentation and website label Mar 29, 2022
@svlandeg svlandeg closed this Mar 29, 2022
@svlandeg svlandeg reopened this Mar 29, 2022
@svlandeg
Copy link
Member

svlandeg commented Mar 29, 2022

@svlandeg it was easier to create a new PR.

This still doesn't look quite right though. What you want to do is update your master branch with spaCy's latest master first, then create a new branch off that, cherry-pick the edit adding this universe entry, then create a new PR. The PR shouldn't have duplicate commits that were already merged into master ...

UPDATE: you probably need to redo your master branch entirely:

image

@polm polm added the universe Changes to the Universe directory of third-party spaCy code. label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation and website universe Changes to the Universe directory of third-party spaCy code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants