Add check for single quoted values #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmitsch
approved these changes
Jan 12, 2023
rmitsch
reviewed
Jan 12, 2023
Co-authored-by: Raphael Mitsch <[email protected]>
rmitsch
requested changes
Jan 12, 2023
Co-authored-by: Raphael Mitsch <[email protected]>
rmitsch
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values in confection are JSON values. One thing that can confuse people is that single quoting such values is not valid, and the quotes will be interpreted as being part of the string, as raised in explosion/spaCy#9454.
This PR checks for values that seem to be single quoted and warns about them.
Also, I hadn't realized it before this PR, but apparently empty values are valid, like this: