Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error msg for type checking #1211

Closed
wants to merge 39 commits into from
Closed

Add error msg for type checking #1211

wants to merge 39 commits into from

Conversation

tiashah1
Copy link

Making the input take "runParser" arguments
Adding error messages instead of returning false or Nothing
Adding some more expressions (e.g. Lambda)

Tia Shah and others added 30 commits December 9, 2024 17:26
Experiment with only Integers
7946864
Experiment with only Integers
675411a
Try adding parsing functionality
8220ea7
Try adding parsing functionality
4820f71
Fix parser for types
afa61c1
Start working on type checking
dc8358e
Try VarDefs
8db8a4b
Add exception handling for types and try Let again
b4fc2af
Add more to reduce & typeCheck
ed261fa
Use check and synth for primitives and BinaryApp
c76b2ea
Use check and synth for primitives and BinaryApp
e3d668c
Use check and synth for primitives and BinaryApp
42fc5cf
Extend check and synth
d62b0b2
Extend check and synth
b9e36a6
Extend check and synth
543580f
Extend check and synth
bca8db7
Extend check and synth and add testing module
d26d0be
Refactor parser to include another type & fixup pattern check and synth
65f1063
Add more to check and synth
cb7e404
Changes from meeting
6f39672
Add record data type and refactor Context to use List
5fe287f
Add to check and synth, fix PRecord
6b3a8e7
test
f4de9eb
comments
09d350f
fix varDef syntax
354fba5
fix TypeChecking update errors
58920f2
@tiashah1
Merge branch 'explorable-viz:develop' into functions-and-integers
fd2e962
fix TypeChecking update errors
85071ac
Add Dictionary support
63053aa
Add error messages and make input come from runParser output
63b76bd
@tiashah1
Copy link
Author

@dorchard FYI
Another draft PR - this time focusing on error messages (and refactoring check and synth to allow us to use (runParser ...) statements as inputs

@dorchard dorchard changed the title Add error msg Add error msg for type checking Jan 13, 2025
@dorchard dorchard added the types label Jan 13, 2025
@tiashah1
Copy link
Author

  • Error messages are a String as we do not have other information currently. New file TypeCheckError
  • Replaced the check and synth functions to allow for: Either a (Expr b)
    • This needs to be amended as incorrect as is
  • Added check and synth patterns for
    • Lambda
    • App
    • MatchAs
    • DProject (only for synth)
    • Matrix (only for check)
  • Altered the Dictionary patterns in check and synth to line up with changes from develop (removing Records, etc.)
    • Added a new type: TDict Types Types

@tiashah1
Copy link
Author

closing this PR and re-opening, instead pointing to the functions-and-integers branch in my own fork
tiashah1#1

@tiashah1 tiashah1 closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiashah1 @dorchard