Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in documentation rag_testset_generation.md: API changes required arguments #1714

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmerkle
Copy link

@bmerkle bmerkle commented Nov 27, 2024

The code in rag_testset_generation.md code not compile and contains 2 syntax errors (API has changed)
I now added missing possitional arguments for embedding_model and documents

added missing possitional arguments for embedding_model and documents
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 27, 2024
@bmerkle
Copy link
Author

bmerkle commented Nov 27, 2024

BTW. how about adding a samples directory with ready to run jupyter notebooks ?
I could contribute the two samples from your documentation as notebooks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant