Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exercises(queen-attack): remove input validation tests #335

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

exercises(queen-attack): remove input validation tests #335

wants to merge 8 commits into from

Conversation

ee7
Copy link
Member

@ee7 ee7 commented Sep 21, 2023 •
edited
Loading

Remove QueenError and the input validation tests. They weren't interesting - there's no good reason for init params to be i8 when the valid range is between 0 and 7 inclusive.

This PR will break everybody's solution, but I think that's worthwhile.

Closes: #223
Refs: #229

To-do:

  • Check whether we should add an .append file that explains how to assert

@ee7 ee7 mentioned this pull request Sep 21, 2023
Open
1 task
@ee7 ee7 self-assigned this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@booniepepper booniepepper booniepepper approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@ee7 ee7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

exercises(queen-attack): consider removing test for negative row/col, and support u3 fields
2 participants
@ee7 @booniepepper