Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change face sorting direction #7176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

vaeng
Copy link
Contributor

@vaeng vaeng commented Nov 29, 2024

I made a fiddle to test the changes.
https://jsfiddle.net/297t4rzm/

@vaeng vaeng requested a review from iHiD as a code owner November 29, 2024 08:56
@iHiD
Copy link
Member

iHiD commented Dec 3, 2024

Thanks!

Reflecting on this, I think it will look better with the faces still stacked how they were but with the order of the faces reversed. I think the right places to do this are:

A .reverse on the end of that probably works perfect.

@vaeng Do you want to do this, or shall I throw it @dem4ron's way? :)

@vaeng
Copy link
Contributor Author

vaeng commented Dec 3, 2024

If @dem4ron can do this and it is not a big job, I'm happy to have him give it a go. I would probably miss a lot of things :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants