Admin partners page improvements #7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dem4ron
commented
Nov 6, 2024
dem4ron
commented
- Import stylesheet
- Add admin component, add width variable
- Adjust adverts perk width + add track slugs
- Add track slugs col
- Add TrackSlugselector, Save values in a hidden field
- Set up default values
- Correctly type multiselect ref, permit track_slugs
- Clarify comment
iHiD
reviewed
Nov 7, 2024
| @@ -30,6 +30,11 @@ | |||
| = f.label :dark_logo, class: 'text-h6 mb-4' | |||
| = f.file_field :dark_logo | |||
|
|
|||
| .flex.flex-col.mb-16 | |||
| = f.label :track_slugs, "Select Tracks", class: 'text-h6 mb-4' | |||
| = render ReactComponents::Common::TrackSlugsMultiselector.new(Track.all.map(&:slug), advert.track_slugs) | |||
There was a problem hiding this comment.
Suggested change
| = render ReactComponents::Common::TrackSlugsMultiselector.new(Track.all.map(&:slug), advert.track_slugs) | |
| = render ReactComponents::Common::TrackSlugsMultiselector.new(Track.pluck(:slug), advert.track_slugs) |
This is like 1000x more efficient (literally)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.