[SVG file] Replace attribute delimiters “ and ” with ASCII " #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was `svgo` that warned me about this file: ~~~bash $ svgo --config svgo-config.js --input features-oop.svg --output test.svg SvgoParserError: features-oop.svg:1:12: Unquoted attribute value > 1 | <svg width=“48” height=“48" viewBox=“0 0 48 48” fill=“none” xmlns=“http://www.w3… | ^ 2 | <path fill-rule=“evenodd” clip-rule=“evenodd” d=“M8.99805 40.5C11.8975 40.5 14.2… 3 | <path d=“M16.498 46.5C15.0208 43.7302 12.1372 42 8.99805 42C5.8589 42 2.97529 43… ~~~ But I see my editor's gutter was too via `xmllint`: ~~~ $ xmllint features-oop.svg features-oop.svg:1: parser error : AttValue: " or ' expected <svg width=“48” height=“48" viewBox=“0 0 48 48” fill=“none” xmlns= ^ features-oop.svg:1: parser error : attributes construct error <svg width=“48” height=“48" viewBox=“0 0 48 48” fill=“none” xmlns= ^ features-oop.svg:1: parser error : Couldn't find end of Start Tag svg line 1 <svg width=“48” height=“48" viewBox=“0 0 48 48” fill=“none” xmlns= ^ features-oop.svg:1: parser error : Extra content at the end of the document <svg width=“48” height=“48" viewBox=“0 0 48 48” fill=“none” xmlns= ^ ~~~ Are we doing any consistency checks with SVG files?
habere-et-dispertire
changed the title
|
@habere-et-dispertire Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was
svgothat warned me about this file:But I see my editor's gutter was too via
xmllint:Are we doing any consistency checks with SVG files?