feat: add high-scores exercise #176
Conversation
| struct HighScores { | ||
| scores []int | ||
| } |
There was a problem hiding this comment.
question: is there a particular reason to do this as a struct instead of just as an array?
There was a problem hiding this comment.
I've just tried
type HighScores = []int
and experienced compiler crashes:
---- Testing... -------------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------------------------
==================
/tmp/v_1000/tsession_7ff928207740_42009345629388/run_test.6178438000952218471.tmp.c:22171: error: cannot convert 'struct array *' to 'struct array'
...
==================
(Use `v -cg` to print the entire error message)
builder error:
==================
C error. This should never happen.
This is a compiler bug, please report it using `v bug file.v`.
https://github.com/vlang/v/issues/new/choose
You can also use #help on Discord: https://discord.gg/vlang
I'll check if this happens with the latest compiler, and if so report a compiler bug.
Even if this approach works, I think high_scores.v should still use struct
There was a problem hiding this comment.
When I tried the type HighScores = []int example solution with a recent V compiler, there were no compiler crashes.
PR to update test runner: exercism/vlang-test-runner#39
There was a problem hiding this comment.
There is a current compiler crash if we make a small change to the personal_top_three() example solution.
See vlang/v#20075
The crash is avoided in the example solution uploaded for this PR.
There was a problem hiding this comment.
The compiler bug has been fixed. :-)
I expect the fix will be in weekly.2023.49 weekly.2023.50
There was a problem hiding this comment.
Great! Let's wait until the compiler update and once your exercism/vlang-test-runner#39 gets merged in, we can merge this one in too
High scores example solution uses int array instead of a struct, as the HighScores type.
|
exercism/vlang-test-runner#39 is ready to be merged, then this can be merged. |
|
Thanks so much! |
The last four canonical test cases for this exercise check that calling one method doesn't stop another method from returning the correct result.
These test cases are the reason I used
(mut high_scores HighScores)- without themut, those test cases would be largely redundant.