Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue143 #166

Closed
wants to merge 23 commits into from
Closed

Issue143 #166

wants to merge 23 commits into from

Conversation

axtens
Copy link
Member

@axtens axtens commented Jul 19, 2022

Responding to issue #143, specifying a specific exception.
Should all tests specify specific exceptions?
Have also changed net5 to net6 and removed a spurious file

@axtens
Copy link
Member Author

axtens commented Jul 19, 2022

I deleted Practice.sln because I thought it was spurious. Now I discover it's there for test.ps1 to work on.
Now what?

@ErikSchierboom
Copy link
Member

I feel like this PR is doing a couple of things. I'd prefer splitting the changes up into separate PRs.

@axtens
Copy link
Member Author

axtens commented Jul 20, 2022

Okay, will close this PR and try again (and not delete the "spurious file")

@axtens axtens closed this Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants