This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[C#] Namespace concept. Red vs Blue. Tests #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin-p
changed the title
mikedamay
reviewed
Nov 16, 2020
There was a problem hiding this comment.
This looks good.
I was not sure why the warnings were disabled. I did not see them on my build when I removed the pragma. If we can't get rid of them I suppose we will need to introduce the compiler directive concept.
@ErikSchierboom what do you think?
|
We can disable pragma in the project file too if necessary. |
ErikSchierboom
approved these changes
Nov 17, 2020
languages/csharp/exercises/concept/red-vs-blue-darwin-style/RedVsBlueDarwinStyleTests.cs
Outdated
Show resolved
Hide resolved
languages/csharp/exercises/concept/red-vs-blue-darwin-style/RedVsBlueDarwinStyle.cs
Outdated
Show resolved
Hide resolved
languages/csharp/exercises/concept/red-vs-blue-darwin-style/.meta/Example.cs
Outdated
Show resolved
Hide resolved
languages/csharp/exercises/concept/red-vs-blue-darwin-style/RedVsBlueDarwinStyleTests.cs
Outdated
Show resolved
Hide resolved
languages/csharp/exercises/concept/red-vs-blue-darwin-style/RedVsBlueDarwinStyleTests.cs
Outdated
Show resolved
Hide resolved
|
I did not really understand the inline issue so @ErikSchierboom can you review the changes. |
ErikSchierboom
approved these changes
Nov 17, 2020
|
Thanks @valentin-p! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not add any unit tests for the aliases Red/Blue.
Closes #2026