Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function signature comments #29

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add function signature comments #29

merged 1 commit into from
Nov 14, 2024

Conversation

ErikSchierboom
Copy link
Member

No description provided.

@ErikSchierboom ErikSchierboom mentioned this pull request Nov 14, 2024
Open
26 tasks
@vaeng
Copy link
Contributor

vaeng commented Nov 14, 2024 •
edited
Loading

It looks really neat with a general comment as well:

uiua pad:
Screenshot 2024-11-14 104226

VS Code:
image

Do you think we should prep all stubs this way?

@ErikSchierboom
Copy link
Member Author

It looks really neat with a general comment as well:

Maybe we add those too then!

Do you think we should prep all stubs this way?

I think so.

@ErikSchierboom
Copy link
Member Author

@vaeng I've updated them all

vaeng
vaeng approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, that will make it easier to navigate the stub code for students

@vaeng vaeng mentioned this pull request Nov 14, 2024
Merged
@ErikSchierboom ErikSchierboom merged commit dc44e7f into main Nov 14, 2024
2 checks passed
@ErikSchierboom ErikSchierboom deleted the parameter-comments branch November 19, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaeng vaeng vaeng approved these changes

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErikSchierboom @vaeng @SleeplessByte