Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HighScoreBoardTests.swift #769

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Update HighScoreBoardTests.swift #769

merged 1 commit into from
Sep 12, 2024

Conversation

landmaj
Copy link
Contributor

@landmaj landmaj commented Sep 10, 2024

In the High Score Board exercise resetScore function is described as this:

The function will set the score of the player to 0. If the player is not in the dictionary, then nothing should happen.

There is no test case to validate resetting nonexistent player's score, which makes this code pass, even though it should not:

func resetScore(_ scores: inout [String: Int], _ name: String) {
  scores[name] = 0
}

This PR adds the missing test case.

Copy link
Contributor

Hello 👋 Thanks for your PR.

This repo does not currently have dedicated maintainers. Our cross-track maintainers team will attempt to review and merge your PR, but it will likely take longer for your PR to be reviewed.

If you enjoy contributing to Exercism and have a track-record of doing so successfully, you might like to become an Exercism maintainer for this track.

Please feel free to ask any questions, or chat to us about anything to do with this PR or the reviewing process on the Exercism forum.

(cc @exercism/cross-track-maintainers)

@meatball133 meatball133 merged commit 07f1f14 into exercism:main Sep 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants